Display name of a drive

[vohtaski]

Thanks for the nice module!

Would it be possible to display a device name?
For example, my usb drive has this name PHY_RH_252.
But I don't see it in the list of options
On mac:

description:"AT90USB128 M S"
device:"/dev/disk3"
mountpoints: {
    path:"/Volumes/PHY_RH_252"
    raw:"/dev/rdisk3"
size:3980394496
system:false

On windows:

description:"ATMEL AT90USB128 M S USB DEVICE"
device:"\\.\PHYSICALDRIVE1"
mountpoints:
    path:"D:"
    raw:"\\.\PHYSICALDRIVE1"
size:3980394496
system:false

[jviotti]

Hi @vohtaski,

Drivelist lists the top level drives, and therefore includes the top level drive name in the description property, which is usually slightly different across platforms (depends on what the OS interprets the name), which in your example is "AT90USB128 M S" and "ATMEL AT90USB128 M S USB DEVICE".

"PHY_RH_252", in the other hand, is the name of one of the partitions. I'd love to have this functionality as name or description properties included in the mount-points array.

How do you feel about trying a PR yourself? I can help with any OS you don't have access to.

[vohtaski]

PR should be good. We definitely need it for the project at my work.
I just can't say for now if it's next week or couple weeks into the future :)

[vohtaski]

@jviotti
I finally managed to find some time to work on this issue.
My changes for windows and darwin are here.
Should be similar to linux but I dont have linux machine to test.
vohtaski@f9a8195

I introduced a name volumeName next to path in mountpoints array.
Should I submit a PR?

[jviotti]

Hi @vohtaski ,

Sorry for the delay! A PR would be very welcomed! When you create it, can you tick the option to allow the project maintainers to make changes to the PR? I can jump in and push Linux support there.