Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in target process jumping into invalid memory #25

Closed
baldurk opened this issue Mar 13, 2014 · 1 comment
Closed

Crash in target process jumping into invalid memory #25

baldurk opened this issue Mar 13, 2014 · 1 comment
Labels
Bug A crash, misbehaviour, or other problem

Comments

@baldurk
Copy link
Owner

baldurk commented Mar 13, 2014

For reasons currently unknown, sometimes using CreateToolhelp32Snapshot to find the renderdoc dll in the target process can fail, leading to jumping into 0x0+RENDERDOC_SetLogFile instead of renderdoc.dll+RENDERDOC_SetLogFile.

I've put a change in that will be included in v0.19 that includes better logging, a speculative fix and slightly more graceful handling of this happening.

@baldurk
Copy link
Owner Author

baldurk commented Apr 30, 2014

Figured this out, the module list from the snapshot can sometimes return renderdoc as RENDERDOC.DLL even if nothing refers to it as upper case. I'm sure there's a good reason for it, but since I didn't need a case sensitive comparison while looking for the module I made it case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A crash, misbehaviour, or other problem
Projects
None yet
Development

No branches or pull requests

1 participant