Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate marketplace entries on dashboard #734

Closed
zk opened this issue Nov 1, 2013 · 9 comments
Closed

Duplicate marketplace entries on dashboard #734

zk opened this issue Nov 1, 2013 · 9 comments

Comments

@zk
Copy link

zk commented Nov 1, 2013

We recently updated our prod marketplace key. When we added that new key to the dashboard (via https://www.balancedpayments.com/marketplaces/?embedded=1) it resulted in adding duplicates:

@mjallday
Copy link
Contributor

mjallday commented Nov 7, 2013

@dmdj03 it should be possible for marketplaces to have multiple API keys. a good example of this would be if the marketplace was rotating their API key, they have to create and associate a second key with the marketplace and then, sometime in the future, remove the old key. however, there is no fixed number of keys.

some keys may also have attributes such as being read-only.

can you please mock something for this so we can implement a better solution that showing duplicate marketplaces?

@tarunc
Copy link
Contributor

tarunc commented Dec 4, 2013

@dmdj03 ping

Whats happening with this?

@dmdj03
Copy link

dmdj03 commented Dec 6, 2013

screen shot 2013-12-05 at 7 11 37 pm
screen shot 2013-12-05 at 7 10 31 pm
screen shot 2013-12-05 at 7 10 39 pm
screen shot 2013-12-05 at 7 10 49 pm
screen shot 2013-12-05 at 7 14 41 pm

@mjallday
Copy link
Contributor

mjallday commented Dec 6, 2013

Looking good.

Access Key ID should be ID, and in the mock you have the ID and secret of the way in the wrong places, they should be swapped around.

What does the - button next to the "Create new key" link do? Expand and collapse the keys?

@dmdj03
Copy link

dmdj03 commented Dec 6, 2013

Replaced the "-" with "X" so you don't confuse it as an expand/collapse function

screen shot 2013-12-09 at 11 58 50 am

screen shot 2013-12-09 at 11 55 58 am

@mjallday
Copy link
Contributor

mjallday commented Dec 6, 2013

This looks great @dmdj03

What's the strategy for building this:

  • Should it be implemented with this new look-and-feel while keeping the rest of the site the way it is?
  • Should we implement it with the current styles?
  • Should revamp the whole site?

@tarunc
Copy link
Contributor

tarunc commented Feb 1, 2014

@mjallday We missed this issue. Should I work on this with the old styles?

@mjallday
Copy link
Contributor

mjallday commented Feb 3, 2014

@tarunc don't redefine the headers, fonts or modal styles but the rest should probably be new since it's new functionality. let's sync up with @dmdj03 when you are both in the office and work out a migration strategy for the new styles in general.

@dmdj03
Copy link

dmdj03 commented Feb 22, 2014

This is being addressed in #988 and #28

@dmdj03 dmdj03 closed this as completed Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants