Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RingBuffer.hxx #776

Open
balazsracz opened this issue Feb 3, 2024 · 0 comments
Open

Remove RingBuffer.hxx #776

balazsracz opened this issue Feb 3, 2024 · 0 comments
Labels
cleanup

Comments

@balazsracz
Copy link
Collaborator

There seems to be two classes with the same functionality, DeviceBuffer.hxx and RingBuffer.hxx.

We could probably remove RingBuffer.hxx. It seems it is used in two places.
Stream.hxx which is code that was never finished and doesn't even compile.
Pipe.hxx which should likely rather utilize the DeviceBuffer since it should really have select support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balazsracz