Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Status Code 304 Should Be Considered Successful #310

Closed
cmcnicholas opened this issue Jul 21, 2021 · 1 comment · Fixed by #311
Closed

HTTP Status Code 304 Should Be Considered Successful #310

cmcnicholas opened this issue Jul 21, 2021 · 1 comment · Fixed by #311
Labels
released

Comments

@cmcnicholas
Copy link
Contributor

Is this a bug report or a feature request?

the library currently waits for a successful 200 response indicating ready, but 304 not modified should also be considered successful as it is used for caching.
@cmcnicholas cmcnicholas mentioned this issue Jul 21, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): adds check for http status 304
1 participant
@cmcnicholas