Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just do "Get Gelocation id" one time, not on every Iteration-Cyrcle #41

Closed
baerengraben opened this issue May 21, 2021 · 3 comments
Closed

Comments

@baerengraben
Copy link
Owner

The new API limits the Calls to 50/day. So we need to be sparing with the requests. the geolocation id actually only needs to be read the first time for requesting the forecasts. After that, the value can be used again for each forecast request.

@cdellasanta
Copy link

cdellasanta commented May 23, 2021

I wanted to write a new issue, but this one I think this explains the behaviour i wanted to report:
image

How many requests are currently done for every Iteration-Cyrcle?
I assume 3-4 (given 50 limit / 15 success = 3.333) ... maybe you can foresee additional configuration params, to get more control on how many requests are done every cycle ..

@baerengraben
Copy link
Owner Author

Hi @cdellasanta
Per iteration cycle I did 3 requests:

  • getToken
  • get geolocationId (is needed for getting forecast)
  • get forecast (delivers the final forecast)

So I do 3 calls per iteration. Where I assume that the "getToken" call is not really counted as a request.

I did a fix today. now the geolocation id is read only 1x and reused afterwards. So in the actual version (current master branch in Github) 49 forecast calls should be possible. I am currently testing this and, if successful, I will make a new release 0.9.1.

@baerengraben
Copy link
Owner Author

resolved with release 0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants