Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This extension may soon no longer be supported in Chrome #92

Closed
t1m0thyj opened this issue Aug 3, 2024 · 11 comments
Closed

This extension may soon no longer be supported in Chrome #92

t1m0thyj opened this issue Aug 3, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@t1m0thyj
Copy link
Contributor

t1m0thyj commented Aug 3, 2024

Chrome is phasing out support for Manifest V2 extensions. In order to continue working in Chrome this extension will need to migrate to Manifest V3: https://developer.chrome.com/docs/extensions/develop/migrate

@t1m0thyj t1m0thyj added the enhancement New feature or request label Aug 3, 2024
@AndreaLeidi
Copy link

Hope never dies but the latest update dates back to January 9, 2022. Sadly, I think it's time to consider this project abandoned.

@mpegram3rd
Copy link

There's a Draft PR started back earlier in this year on the v4 branch (#86) that appears to be an attempt to fix the issue @badsgahhl is there anything the user community can do to help get that over the finish line?

@badsgahhl
Copy link
Owner

I hope I find the time to look into it the upcoming weeks.

@AndreaLeidi
Copy link

Hi @badsgahhl and thanks! PiHole Browser Extension is very useful and well done.

@stanthewizzard
Copy link

yes very useful

@johnnykang
Copy link

just wondering if there is any update on this as 2024 is closing.

@badsgahhl
Copy link
Owner

badsgahhl commented Dec 20, 2024

As mentioned, I really don't use PiHole on my own anymore and therefore I reprioritize this project further low in my daily schedule. I started with the V4 Implementation but still needs fine-tuning. Mostly Manifest V3 ist breaking a lot of stuff. Really have no time when this is going to be released, sorry to say.

@t1m0thyj
Copy link
Contributor Author

t1m0thyj commented Dec 20, 2024

@badsgahhl Are you open to contributions to the extension? Since I actively use PiHole, I wouldn't mind daily driving the V4 implementation that's WIP and opening a PR to fix whatever breaks.

@t1m0thyj
Copy link
Contributor Author

t1m0thyj commented Dec 22, 2024

Since the V4 branch has a lot of WIP refactoring, I've forked master branch instead and migrated it to use Manifest V3: master...t1m0thyj:pihole-browser-extension:master

With the changes I've made basic functionality is working. I'll keep testing my branch and see if I hit issues. All behavior should be same as original, except the check status interval changed from 15 to 30 seconds due to limitations of the chrome.alarms API.

@badsgahhl
Copy link
Owner

Since the V4 branch has a lot of WIP refactoring, I've forked master branch instead and migrated it to use Manifest V3: master...t1m0thyj:pihole-browser-extension:master

With the changes I've made basic functionality is working. I'll keep testing my branch and see if I hit issues. All behavior should be same as original, except the check status interval changed from 15 to 30 seconds due to limitations of the chrome.alarms API.

Will look into that!

@badsgahhl
Copy link
Owner

Thanks a lot for the work! Updates will be pushed throw the stores in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants