Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Assignment not applied on Add to Whitelist #91

Open
kanjieater opened this issue Jul 25, 2024 · 0 comments
Open

Group Assignment not applied on Add to Whitelist #91

kanjieater opened this issue Jul 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kanjieater
Copy link

Describe the bug
This may be a feature - apologies if I'm missing something. When adding a whitelisted domain from the extension, if adds it, but does not add it to a group. Therefore it doesn't apply it, and the list is still blocked.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you have t.co blocked via lists
  2. Go to twitter and click on someones external t.co link
  3. Add t.co via the extension when it's blocked
  4. See in the Domains, and look at the List of domains, it's added but not applied to any group. image
  5. Manually update each domain added via whitelist on all piholes

Expected behavior
At step 3, the extension should also set the default group assignment. A potential feature enhancement may be to set the group assignment in the ext settings.
End result should look like this:
image

Screenshots
See above

Desktop (please complete the following information):

  • OS: Win 11
  • Browser Chrome
  • Version 126.0.6478.128

Additional context
none

@kanjieater kanjieater added the bug Something isn't working label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant