Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change duration #57

Closed
upD8R opened this issue Jan 6, 2022 · 4 comments
Closed

Cannot change duration #57

upD8R opened this issue Jan 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@upD8R
Copy link

upD8R commented Jan 6, 2022

Describe the bug
I cannot change the default of 10s. Whatver duration is already set (on some boxes I have previously configured 600s) I cannot change the duration anymore. Whatever duration is used, the enabling of Pihole happens after just a few seconds again.

To Reproduce
Steps to reproduce the behavior:
Try to to change the duration by entering numbers or using the up and down arrows.
If I close the popup it defaults back to 10s (or the previous value) only.
Disabling PiHole by clicking the icon => slider only lasts a few seconds, even if a much bigger time is set.

Expected behavior
Accept any time (my default is usually 600s)

Desktop (please complete the following information):

  • OS: Win 11
  • Browser: Chrome 97.0.4692.71
  • Extension: 3.0.1
  • Pihole v5.8.1

Additional context
This issue is not related to Win 11, it also happens on my Win 10 boxes.

@upD8R upD8R added the bug Something isn't working label Jan 6, 2022
@badsgahhl
Copy link
Owner

badsgahhl commented Jan 6, 2022

Hi,
unfortunately I cannot reproduce this behavior in 3.0.1. If i change the default disable time either in the settings or in the popup it self, it will be used in the disabling process.

image
image

@upD8R
Copy link
Author

upD8R commented Jan 6, 2022

Thanks for the quick response, indeed I can change it in the settings, so I set it to 600s now. So this seems to be fine.
Nevertheless, if I disable Pihole now in the popup it diables it (for 600s) but the icon turns back to "on" after a few seconds, Pihole itself is still disabled.
In the screenshot you can see that the status is different in the icon and in Pihole itself,
image

@badsgahhl
Copy link
Owner

Yes this is another bug which is already discussed here pi-hole/web#2051 (comment)
and there
#54 (comment)

@upD8R
Copy link
Author

upD8R commented Jan 6, 2022

I see, thanks, Then we can close here! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants