Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a way to get images from image cache that supports a reverse proxy #1139

Closed
daredoes opened this issue Jun 27, 2023 · 3 comments
Closed
Labels
next release fixed in develop branch and will be part of the next release

Comments

@daredoes
Copy link

Currently, the art data URL is formed from the settings host and port values under http.

What I think would be ideal is some way to send the image data itself to the snapcast client so it can store a cached version itself on the client.

https://github.com/badaix/snapcast/blob/481f08199ca31c60c9a3475f1064e6b06a503d12/server/streamreader/pcm_stream.cpp#L489C88-L489C92

@badaix
Copy link
Owner

badaix commented Mar 6, 2024

Don't know how your infrastructure looks like, but if the client is talking to the server via the proxy, doesn't it work to set the [http] host value to the IP of the proxy?

@daredoes
Copy link
Author

daredoes commented Mar 6, 2024

So I'm using a reverse proxy, which means that I have to use a web address, not an IP address.

currently i have host set to 0.0.0.0 so it binds to the network.

@badaix badaix added the next release fixed in develop branch and will be part of the next release label Jan 16, 2025
@badaix
Copy link
Owner

badaix commented Jan 17, 2025

Fixed in Snapcast v0.30.0

@badaix badaix closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

No branches or pull requests

2 participants