Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lineage assignment into a model object #79

Closed
johnlees opened this issue May 6, 2020 · 1 comment · Fixed by #108
Closed

Make lineage assignment into a model object #79

johnlees opened this issue May 6, 2020 · 1 comment · Fixed by #108
Labels
code Changes to the coding implementation

Comments

@johnlees
Copy link
Member

johnlees commented May 6, 2020

Move the existing code so that it follows the inheritance structure of the other models.
Changing the command line options to give model type when using --fit-model would also make sense.

@johnlees johnlees added the code Changes to the coding implementation label May 6, 2020
@nickjcroucher
Copy link
Collaborator

Since a75cb4f, the lineage assignment code should be in the correct part of the main routines for conversion to a model type. I've put in some comments where there are temporary fixes to allow this which will probably need to be undone (e.g. where there is a model.save() command).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Changes to the coding implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants