Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify route.spec.host if the name is greater than 63 characters #8

Open
alaypatel07 opened this issue Nov 10, 2021 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@alaypatel07
Copy link
Contributor

Describe the bug
Route name should not be longer than 63 characters otherwise it will not get accepted

Steps to reproduce
Pass a namespaced name that is longer than 63 characters to the route.New() constructor

Expected behavior
Routes names should be validated. If the route names is greater than 63 chars, the spec.host should be specified that should be unique for this route as well as each laber should be smaller than 63 characters in ..

Actual results
The first label gets derivied from the name of the route, if the name is longer than 63 characters, the routes will never get admitted.

@alaypatel07 alaypatel07 added the bug Something isn't working label Nov 10, 2021
@alaypatel07
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant