Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 5 files changed
- 1 contributor
Commits on May 29, 2020
Commits on May 30, 2020
-
Merge pull request #344 from babel/remove-travis-appveyor
Remove Travis & AppVeyor
Commits on Jun 2, 2020
-
Ensure Ember modules API related globals do not share AST Nodes
The original fix in ember-cli/babel-plugin-ember-modules-api-polyfill#109 attempted to cache the generated member expressions, so that we didn't do duplicated work for each reference to a given global. Unfortunately, this optimization failed to take into consideration that most babel plugins work by directly mutating the node in question. In practice what that meant was that once _any_ usage of a given global was needed to be transformed (e.g. say you had `computed(...args, function(){})` and are transpiling for IE11), then all usages of that global would be mutated. A more concrete example. ```js // input import { computed } from '@ember/object'; function specialComputed(dependentKeys) { return computed(...dependentKeys, function() {}); } function otherLessSpecialComputed() { return computed('stuff', 'hard', 'coded', function() {}); } ``` In this example, the first method (`specialComputed`) needs to be transpiled to something akin to (most of the changes here are from `@babel/plugin-transform-spread`): ```js function specialComputed(dependentKeys) { return Ember.computed.apply(Ember, dependentKeys.concat([function() {}])); } ``` Unfortunately, since the generated `MemberExpression` for `Ember.computed` is shared, this forced the other `computed` usage to be transpiled to: ```js function otherLessSpecialComputed() { return Ember.computed.apply('stuff', 'hard', 'coded', function() {}); } ``` Which is clearly, **totally** invalid. 🤦
-
There are no files selected for viewing
This file was deleted.
This file was deleted.