This repository has been archived by the owner on May 19, 2018. It is now read-only.
Disallow SpreadElement inside dynamic import #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
May 17, 2017
existentialism
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| Breaking change? | no |
| New feature? | no |
| Deprecations? | no |
| Spec compliancy? | yes |
| Tests added/pass? | yes |
| Fixed tickets | Fixes #527 |
| License | MIT |
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 98.27% 98.27% +<.01%
==========================================
Files 22 22
Lines 3531 3535 +4
Branches 980 982 +2
==========================================
+ Hits 3470 3474 +4
Misses 22 22
Partials 39 39
Continue to review full report at Codecov.
|
hzoo
reviewed
May 17, 2017
| } | ||
|
|
||
| const importArg = node.arguments[0]; | ||
| if (importArg && importArg.type === "SpreadElement") { |
There was a problem hiding this comment.
maybe use ... instead of SpreadElement and tt.ellipsis
hzoo
approved these changes
May 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.