Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Type-check ExpressionParser #488

Merged
merged 3 commits into from May 11, 2017
Merged

Type-check ExpressionParser #488

merged 3 commits into from May 11, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2017

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? Tests pass
Fixed tickets
License MIT

Enables type-checking in the file and annotates all methods.
Requires a few forward-declarations for statement.js. parseClass might deserve its own file; same for decorator-related methods. But trying to just do type annotations in this PR.

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #488 into master will decrease coverage by <.01%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files          22       22              
  Lines        3526     3525       -1     
  Branches      978      978              
==========================================
- Hits         3465     3464       -1     
  Misses         22       22              
  Partials       39       39
Flag Coverage Δ
#babel 81.07% <95.74%> (-0.01%) ⬇️
#babylon 97.1% <97.87%> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/parser/expression.js 97.38% <97.87%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1773ca7...6e6b599. Read the comment docs.

@ghost ghost mentioned this pull request Apr 26, 2017
@ghost
Copy link
Author

ghost commented Apr 27, 2017

Codecov is having problems here; don't know where the coverage was lost.
screenshot

@danez danez merged commit a738870 into babel:master May 11, 2017
@ghost ghost deleted the expression branch May 11, 2017 14:35
@ghost ghost mentioned this pull request May 12, 2017
@ghost ghost mentioned this pull request May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants