-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Alpha 12 #5808
⬆️ Alpha 12 #5808
Conversation
hzoo
commented
Jun 1, 2017
Codecov Report
@@ Coverage Diff @@
## 7.0 #5808 +/- ##
==========================================
- Coverage 84.91% 84.86% -0.06%
==========================================
Files 284 284
Lines 9928 9928
Branches 2788 2787 -1
==========================================
- Hits 8430 8425 -5
- Misses 988 990 +2
- Partials 510 513 +3
Continue to review full report at Codecov.
|
const location = { | ||
start: { | ||
line: loc.line, | ||
column: loc.column + 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sucks... Is the +1
expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh? in our code it was +1 already? I just copied it over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking it should just work ™️ with existent AST loc objects. That was the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any tests for it probably so I didn't really check, dono if you want to take a look
still calls deprecated method: #5815 |