Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Add logs for polyfills. #59

Merged
merged 5 commits into from
Dec 5, 2016
Merged

Conversation

yavorsky
Copy link
Member

@yavorsky yavorsky commented Dec 5, 2016

  1. Added Using polyfills: to log when debug is enabled.
  2. Log module before Using plugins: row.

@hzoo
Copy link
Member

hzoo commented Dec 5, 2016

Not sure about committing the lock file for the project but that's just me? Is that what we're all doing now? Seems weird because a consumer/user could have a later version with ^ that is broken and we wouldn't know unless we have greenkeeper + yarn

@hzoo
Copy link
Member

hzoo commented Dec 5, 2016

I see the CI auto picks it up with the lock file but yarn only works on node 4 and 0.10/0.12 still uses npm so that concern is not a big deal unless we drop those.

@yavorsky
Copy link
Member Author

yavorsky commented Dec 5, 2016

@hzoo yes, nice point! Moreover it must be added with the separate PR. Just forgot about it.

This reverts commit 80f93f4.
@hzoo
Copy link
Member

hzoo commented Dec 5, 2016

Given we are doing node 0.10 still we are covered so yeah another pr

a[b] = envList[b];
return a;
}, {});
const logStr = `\n ${plugin} ${JSON.stringify(filteredList)}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the \n given its separate console.logs? I see that it's newlines? (Unless you think it looks better that way)

Using plugins:

 syntax-trailing-function-commas {}

Using polyfills:

 es6.typed.data-view {}

 es6.reflect.apply {}

 es6.reflect.own-keys {}

 es6.symbol.iterator {}

 es6.symbol.species {}

 es6.array.from {}
Using plugins:
syntax-trailing-function-commas {}

Using polyfills:
es6.typed.data-view {}
es6.reflect.apply {}
es6.reflect.own-keys {}
es6.symbol.iterator {}
es6.symbol.species {}
es6.array.from {}

@hzoo hzoo merged commit f6584fe into babel:builtins-option Dec 5, 2016
@hzoo
Copy link
Member

hzoo commented Dec 5, 2016

Thanks again @yavorsky (added you as a collab to this repo if you'd like)

@yavorsky
Copy link
Member Author

yavorsky commented Dec 5, 2016

@hzoo Thanks! Glad to help you in future! 👍

hzoo pushed a commit that referenced this pull request Dec 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants