-
-
Notifications
You must be signed in to change notification settings - Fork 158
Conversation
Not sure about committing the lock file for the project but that's just me? Is that what we're all doing now? Seems weird because a consumer/user could have a later version with |
I see the CI auto picks it up with the lock file but yarn only works on node 4 and 0.10/0.12 still uses npm so that concern is not a big deal unless we drop those. |
@hzoo yes, nice point! Moreover it must be added with the separate PR. Just forgot about it. |
This reverts commit 80f93f4.
Given we are doing node 0.10 still we are covered so yeah another pr |
a[b] = envList[b]; | ||
return a; | ||
}, {}); | ||
const logStr = `\n ${plugin} ${JSON.stringify(filteredList)}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need the \n
given its separate console.logs? I see that it's newlines? (Unless you think it looks better that way)
Using plugins:
syntax-trailing-function-commas {}
Using polyfills:
es6.typed.data-view {}
es6.reflect.apply {}
es6.reflect.own-keys {}
es6.symbol.iterator {}
es6.symbol.species {}
es6.array.from {}
Using plugins:
syntax-trailing-function-commas {}
Using polyfills:
es6.typed.data-view {}
es6.reflect.apply {}
es6.reflect.own-keys {}
es6.symbol.iterator {}
es6.symbol.species {}
es6.array.from {}
Thanks again @yavorsky (added you as a collab to this repo if you'd like) |
@hzoo Thanks! Glad to help you in future! 👍 |
Using polyfills:
to log when debug is enabled.Using plugins:
row.