Skip to content
This repository has been archived by the owner on May 11, 2018. It is now read-only.

Version numbers should be string not numbers #187

Closed
danez opened this issue Mar 3, 2017 · 6 comments
Closed

Version numbers should be string not numbers #187

danez opened this issue Mar 3, 2017 · 6 comments
Assignees
Milestone

Comments

@danez
Copy link
Member

danez commented Mar 3, 2017

As we are currently using numbers for targets, it can happen that too much plugins get applied although not necessary.

{
  node: 6.10,
}

This will apply unnecessary transforms as 6.1 < 6.9

Using targets:
{
  "node": 6.1
}

Modules transform: commonjs

Using plugins:
  transform-es2015-destructuring {"node":6.1}
  transform-es2015-for-of {"node":6.1}
  transform-es2015-function-name {"node":6.1}
  transform-exponentiation-operator {"node":6.1}
  transform-async-to-generator {"node":6.1}
  syntax-trailing-function-commas {"node":6.1}
@danez danez added the i: bug label Mar 3, 2017
@danez danez added this to the 2.0 milestone Mar 3, 2017
@danez
Copy link
Member Author

danez commented Mar 3, 2017

#114

@spencerhakim
Copy link

The new invertedEqualsEnv code from #180 should be easy to modify to instead use the semver package, no? So that we don't have to wait for 2.0 or for #114 to be fixed and merged. I can submit a PR if that'd help.

@danez
Copy link
Member Author

danez commented Mar 8, 2017

@spencerhakim Yes true, but I'm not talking about invertedEqualsEnv but the user supplied options which will be fixed in #114.

But good catch we also need to use semver in invertedEqualsEnv though it cannot fail there currently as compat-table has no version '>=x.10' defined (yet).

@yvele
Copy link

yvele commented Mar 27, 2017

I juste made #227 but I'm closing it as it seems to be a duplicate of this one..

@damonmaria
Copy link

I suspect this issue will become a lot more common now that AWS Lambda is running Node 6.10.

@existentialism
Copy link
Member

existentialism commented Apr 11, 2017

We landed string support in #231.

We can add another issue for supporting things operators and ranges like "chrome": ">= 53" separately after #114 lands.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants