Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

babel-eslint 5.0.0-beta4 causes eslint errors #218

Closed
balupton opened this issue Nov 30, 2015 · 5 comments
Closed

babel-eslint 5.0.0-beta4 causes eslint errors #218

balupton opened this issue Nov 30, 2015 · 5 comments
Labels
bug

Comments

@balupton
Copy link

eslint/eslint#4575
@hzoo hzoo added the bug label Nov 30, 2015
@hzoo
Copy link
Member

hzoo commented Nov 30, 2015

Need to account for setters/getters

@balupton
Copy link
Author

Thanks for the speedy reply!

Need to account for setters/getters

Is this an instruction for me or the babel-eslint team?

@hzoo
Copy link
Member

hzoo commented Nov 30, 2015

Sorry, yeah it's not clear - that is for me. (We need to account*)

@hzoo hzoo mentioned this issue Dec 1, 2015
Closed
@clebert clebert mentioned this issue Dec 2, 2015
Closed
@hzoo hzoo mentioned this issue Dec 4, 2015
Closed
This was referenced Dec 5, 2015
Merged
Merged
Closed
@hzoo
Copy link
Member

hzoo commented Dec 9, 2015

Fixed with babel/acorn-to-esprima@651f5a9

@hzoo hzoo closed this as completed Dec 9, 2015
@hzoo
Copy link
Member

hzoo commented Dec 9, 2015

Published [email protected] which hopefully fixes this.

stevenjob added a commit to stevenjob/babel-eslint that referenced this issue Oct 11, 2016
@stevenjob
Refactor non-regression tests to fix test failures
6472d3d 
Moved backtick to fix test 'getter/setter babel#218' as indent matters
Fixed line numbers for some tests
stevenjob added a commit to stevenjob/babel-eslint that referenced this issue Oct 11, 2016
@stevenjob
Refactor non-regression tests to fix test failures
09a6978 
Moved backtick to fix test 'getter/setter babel#218' as indent matters
Fixed line numbers for some tests
stevenjob added a commit to stevenjob/babel-eslint that referenced this issue Oct 11, 2016
@stevenjob
Refactor non-regression tests to fix test failures
909fe3f 
Moved backtick to fix test 'getter/setter babel#218' as indent matters
Fixed line numbers for some tests
hzoo pushed a commit that referenced this issue Oct 17, 2016
@stevenjob @hzoo
Now using template strings (#410)
88e39ad 
* Use template strings in non-regression tests

* Refactor non-regression tests to fix test failures

Moved backtick to fix test 'getter/setter #218' as indent matters
Fixed line numbers for some tests

* Use template strings in babel-eslint tests

* Fix tests for babel-eslint

Avoids error that shows when using template strings for tests:
	line 253 line comments
	line 260 block comments
	line 306 jsdoc

Error: At loc.start.column: are different (6 !== 0)

* Other small template literal changes

* Add unpad to correctly indent template literals
@soda0289 soda0289 mentioned this issue Dec 8, 2016
Closed
nicolo-ribaudo pushed a commit to babel/babel that referenced this issue Nov 14, 2019
@stevenjob
Now using template strings (babel/babel-eslint#410)
1f04cab 
* Use template strings in non-regression tests

* Refactor non-regression tests to fix test failures

Moved backtick to fix test 'getter/setter babel/babel-eslint#218' as indent matters
Fixed line numbers for some tests

* Use template strings in babel-eslint tests

* Fix tests for babel-eslint

Avoids error that shows when using template strings for tests:
	line 253 line comments
	line 260 block comments
	line 306 jsdoc

Error: At loc.start.column: are different (6 !== 0)

* Other small template literal changes

* Add unpad to correctly indent template literals
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balupton @hzoo