Merge pull request #118 from hzoo/poly-types

add flow exceptions for polymorphic types (<A>) - Ref #109
babel · Jun 3, 2015 · 270fd53 · 270fd53
2 parents 270cfbd + 0ebdf8b
commit 270fd53
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -163,6 +163,10 @@ function monkeypatch() {
     if (node.typeAnnotation) {
       visitTypeAnnotation.call(this, node.typeAnnotation);
     } else if (node.type === "Identifier") {
+      // exception for polymorphic types: <T>, <A>, etc
+      if (node.name.length === 1 && node.name === node.name.toUpperCase()) {
+        return;
+      }
       this.visit(node);
     } else {
       visitTypeAnnotation.call(this, node);

diff --git a/test/non-regression.js b/test/non-regression.js
@@ -296,6 +296,26 @@ describe("verify", function () {
       );
     });
 
+    it("polymorphpic types #109", function () {
+      verifyAndAssertMessages([
+          "export default function groupByEveryN<T>(array: Array<T>, n: number): Array<Array<?T>> {}"
+        ].join("\n"),
+        { "no-unused-vars": 1, "no-undef": 1 },
+        []
+      );
+    });
+
+    it("types definition from import", function () {
+      verifyAndAssertMessages([
+          "import type Promise from 'bluebird';",
+          "type Operation = () => Promise;",
+          "x: Operation;"
+        ].join("\n"),
+        { "no-unused-vars": 1, "no-undef": 1 },
+        []
+      );
+    });
+
     it("1", function () {
       verifyAndAssertMessages(
         [