From b3485ef7dde5a519e231b52ce00a0b19eba7ec37 Mon Sep 17 00:00:00 2001 From: Gabriel Omar Cotelli Date: Wed, 20 Apr 2022 08:50:35 -0300 Subject: [PATCH] Add Pharo 10 Fix some spelling typos Tidy up the docs --- .gitattributes | 2 + .github/workflows/loading-groups.yml | 2 +- .github/workflows/unit-tests.yml | 2 +- CONTRIBUTING.md | 34 +++--- LICENSE | 2 +- README.md | 17 +-- docs/Installation.md | 112 ------------------ docs/README.md | 13 ++ docs/how-to/how-to-load-in-pharo.md | 82 +++++++++++++ .../how-to-use-as-dependency-in-pharo.md | 42 +++++++ docs/reference/Baseline-groups.md | 16 +++ docs/tutorial/Tutorial-Part-I.md | 12 +- docs/tutorial/Tutorial-Part-II.md | 6 +- docs/tutorial/Tutorial-Part-III.md | 2 +- .../BaselineOfRenoirSt.class.st | 2 +- source/RenoirSt-Core/CssBoxShadow.class.st | 2 +- source/RenoirSt-Core/CssColorStop.class.st | 8 +- .../CssMediaQueryRuleBuilder.class.st | 48 ++++---- .../CssHTMLTypeSelectorTest.class.st | 2 +- .../CssAdjacentSiblingCombinatorTest.class.st | 6 +- .../CssGeneralSiblingCombinatorTest.class.st | 6 +- source/RenoirSt-Tests/CssUnitTest.class.st | 2 +- 22 files changed, 226 insertions(+), 194 deletions(-) delete mode 100644 docs/Installation.md create mode 100644 docs/README.md create mode 100644 docs/how-to/how-to-load-in-pharo.md create mode 100644 docs/how-to/how-to-use-as-dependency-in-pharo.md create mode 100644 docs/reference/Baseline-groups.md diff --git a/.gitattributes b/.gitattributes index da0f990..04b4f49 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1 +1,3 @@ *.st linguist-language=Smalltalk +*.st eol=lf +*.st text diff diff --git a/.github/workflows/loading-groups.yml b/.github/workflows/loading-groups.yml index 1f9eca6..dd5a5dc 100644 --- a/.github/workflows/loading-groups.yml +++ b/.github/workflows/loading-groups.yml @@ -8,7 +8,7 @@ jobs: strategy: fail-fast: false matrix: - smalltalk: [ Pharo64-9.0, Pharo64-8.0 ] + smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0 ] load-spec: [ deployment, deployment-seaside-extensions, tests, tools, development, development-seaside-extensions ] name: ${{ matrix.smalltalk }} + ${{ matrix.load-spec }} steps: diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 4812544..7e76ffb 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - smalltalk: [ Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, Pharo32-7.0 ] + smalltalk: [ Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, Pharo32-7.0 ] name: ${{ matrix.smalltalk }} steps: - uses: actions/checkout@v2 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5464a09..bfeda70 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ -# Contributing +# Contributing -There's several ways to contribute to the project: reporting bugs, sending +There are several ways to contribute to the project: reporting bugs, sending feedback, proposing ideas for new features, fixing or adding documentation, promoting the project, or even contributing code. @@ -11,30 +11,24 @@ You can report issues [here](https://github.com/ba-st/RenoirSt/issues/new) ## Contributing Code - This project is MIT licensed, so any code contribution MUST be under the same license. -- This project uses [Semantic Versioning](http://semver.org/), so keep it in mind - when you make backwards-incompatible changes. If some backwards incompatible - change is made the major version MUST be increased. +- This project uses [Semantic Versioning](http://semver.org/), so keep it in + mind when you make backwards-incompatible changes. If some backwards + incompatible change is made the major version MUST be increased. - The source code is hosted in this repository using the Tonel format in the `source` folder. -- The master branch contains the latest changes and should always be in a - releasable state. +- The `release-candidate` branch contains the latest changes and should always + be in a releasable state. - Feel free to send pull requests or fork the project. - Code contributions without test cases have a lower probability of being merged into the main branch. -### Using Iceberg - -1. Download a [Pharo Image and VM](https://get.pharo.org/64) -2. Clone the project or your fork using Iceberg -3. Open the Working Copy and using the contextual menu select - `Metacello -> Install baseline...` -4. Input `Development-Seaside-Extensions` -5. This will load the base code and the test cases -6. Create a new branch to host your code changes -7. Do the changes -8. Run the test cases -9. Commit and push your changes to the branch using the Iceberg UI -10. Create a Pull Request against the `release-candidate` branch +1. [Load the project code in a Pharo image](docs/how-to/how-to-load-in-pharo.md) +2. Create a new branch to host your code changes +3. Do the changes +4. Run the test cases +5. Commit and push your changes to the branch using the Iceberg UI. You may need + to add your fork if lacking the required permissions to push to the main repo. +6. Create a Pull Request against the `release-candidate` branch ## Contributing documentation diff --git a/LICENSE b/LICENSE index 5ca9e0a..5d93ab6 100644 --- a/LICENSE +++ b/LICENSE @@ -1,6 +1,6 @@ MIT License -Copyright (c) 2013-2021 Gabriel Cotelli, RenoirSt and Buenos Aires Smalltalk Contributors +Copyright (c) 2013-2022 Gabriel Cotelli, RenoirSt and Buenos Aires Smalltalk Contributors Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal diff --git a/README.md b/README.md index 17052f3..4bcc19f 100644 --- a/README.md +++ b/README.md @@ -13,10 +13,12 @@ A DSL enabling programmatic cascading style sheet generation for Pharo Smalltalk [![Pharo 6.1](https://img.shields.io/badge/Pharo-6.1-informational)](https://pharo.org) [![Pharo 7.0](https://img.shields.io/badge/Pharo-7.0-informational)](https://pharo.org) [![Pharo 8.0](https://img.shields.io/badge/Pharo-8.0-informational)](https://pharo.org) +[![Pharo 9.0](https://img.shields.io/badge/Pharo-9.0-informational)](https://pharo.org) +[![Pharo 10](https://img.shields.io/badge/Pharo-10-informational)](https://pharo.org) -Quick links +## Quick links -- [**Explore the docs**](docs/) +- [**Explore the docs**](docs/README.md) - [Report a defect](https://github.com/ba-st/RenoirSt/issues/new?labels=Type%3A+Defect) - [Request a feature](https://github.com/ba-st/RenoirSt/issues/new?labels=Type%3A+Feature) @@ -36,11 +38,9 @@ Quick links - The code is licensed under [MIT](LICENSE). - The documentation is licensed under [CC BY-SA 4.0](http://creativecommons.org/licenses/by-sa/4.0/). -## Quick Start +## Installation -- Download the latest [Pharo 32](https://get.pharo.org/) or [64 bits VM](https://get.pharo.org/64/). -- Download a ready to use image from the [release page](https://github.com/ba-st/RenoirSt/releases/latest) -- Explore the [documentation](docs/) +To load the project in a Pharo image follow this [instructions](docs/how-to/how-to-load-in-pharo.md). *********************************************** @@ -62,11 +62,6 @@ body::before } ``` -## Installation - -To load the project in a Pharo image, or declare it as a dependency of your own -project follow this [instructions](docs/Installation.md). - ## Contributing Check the [Contribution Guidelines](CONTRIBUTING.md) diff --git a/docs/Installation.md b/docs/Installation.md deleted file mode 100644 index f742d44..0000000 --- a/docs/Installation.md +++ /dev/null @@ -1,112 +0,0 @@ -# Installation - -## Basic Installation - -### Pharo 6.1 or greater - -You can load **RenoirSt** evaluating: - -```smalltalk -Metacello new - baseline: 'RenoirSt'; - repository: 'github://ba-st/RenoirSt:release-candidate/source'; - load. -``` - -> Change `release-candidate` to some released version if you want a pinned version - -or if you want to use the Seaside extensions: - -```smalltalk -Metacello new - baseline: 'RenoirSt'; - repository: 'github://ba-st/RenoirSt:release-candidate/source'; - load: 'Deployment-Seaside-Extensions'. -``` - -### Pharo 5 - -- Open a Playground and evaluate: - -```smalltalk -Metacello new - baseline: 'RenoirSt'; - repository: 'github://ba-st/RenoirSt:stable-pharo-50/source'; - load -``` - -or - -- Load it using the Catalog Browser - -### Pharo 4 - -- Open a Playground and evaluate: - -```smalltalk -Metacello new - baseline: 'RenoirSt'; - repository: 'github://ba-st/RenoirSt:stable-pharo-40/source'; - load -``` - -or - -- Load it using the Configuration Browser - -### Pharo 3 (this version is stalled at 1.4.0) - -- Load it using the Configuration Browser - -or - -- Open a workspace and evaluate: - -```smalltalk -Gofer it - url: 'http://smalltalkhub.com/mc/gcotelli/RenoirSt/main'; - configurationOf: 'RenoirSt'; - loadStable -``` - -## Using as dependency - -In order to include **RenoirSt** as part of your project, you should reference -the package in your product baseline: - -```smalltalk -setUpDependencies: spec - - spec - baseline: 'RenoirSt' - with: [ spec - repository: 'github://ba-st/RenoirSt:v{XX}/source'; - loads: #('Deployment') ]; - import: 'RenoirSt'. -``` - -> Replace `{XX}` with the version you want to depend on - -```smalltalk -baseline: spec - - - spec - for: #common - do: [ self setUpDependencies: spec. - spec package: 'My-Package' with: [ spec requires: #('RenoirSt') ] ] -``` - -## Provided groups - -- `Deployment` will load all the packages needed in a deployed application -- `Tests` will load the test cases -- `Tools` will load the extensions to the SUnit framework and development tools - (inspector and spotter extensions) -- `CI` is the group loaded in the continuous integration setup -- `Development` will load all the needed packages to develop and contribute to - the project -- `Deployment-Seaside-Extensions` will load all the packages needed in a deployed - application including the Javascript extensions -- `Development-Seaside-Extensions` will load all the needed packages to develop - and contribute to the project including the Javascript extensions diff --git a/docs/README.md b/docs/README.md new file mode 100644 index 0000000..8a119a9 --- /dev/null +++ b/docs/README.md @@ -0,0 +1,13 @@ +# RenoirSt Documentation + +A DSL enabling programmatic cascading style sheet generation for Pharo Smalltalk. + +To learn about the project, [install it](how-to/how-to-load-in-pharo.md) and +follow the [tutorial](tutorial/Tutorial-TOC.md). + +--- + +To use the project as a dependency of your project, take a look at: + +- [How to use RenoirSt as a dependency](how-to/how-to-use-as-dependency-in-pharo.md) +- [Baseline groups reference](reference/Baseline-groups.md) diff --git a/docs/how-to/how-to-load-in-pharo.md b/docs/how-to/how-to-load-in-pharo.md new file mode 100644 index 0000000..e7be8dd --- /dev/null +++ b/docs/how-to/how-to-load-in-pharo.md @@ -0,0 +1,82 @@ +# How to load RenoirSt in a Pharo image + +## Pharo 6.1 or greater + +### Using Metacello + +1. Download a [Pharo VM and image](https://pharo.org/download) +2. Open your Pharo image +3. Open a Playground +4. Evaluate: + + ```smalltalk + Metacello new + baseline: 'RenoirSt'; + repository: 'github://ba-st/RenoirSt:release-candidate'; + load: 'Development'. + ``` + +> Change `release-candidate` to some released version if you want a pinned version + +### Using Iceberg + +1. Download [pharo VM and image](https://pharo.org/download) +2. Open your Pharo image +3. Open Iceberg +4. Click the *Add* repository button +5. Select *Clone from github.com* and enter `ba-st` as owner name and `RenoirSt` + as project name +6. Click *Ok* +7. Select the repository in the main Iceberg window +8. Open the contextual menu and select + *Metacello -> Install baseline of RenoirSt ...* +9. Type `Development` and click *Ok* + +> After Iceberg cloned a repository, it will be checked-out at the default +> branch (in this case `release-candidate`). If you want to work on a different +> branch or commit, perform the checkout before the baseline installation step. + +## Pharo 5 + +- Open a Playground and evaluate: + +```smalltalk +Metacello new + baseline: 'RenoirSt'; + repository: 'github://ba-st/RenoirSt:stable-pharo-50/source'; + load +``` + +or + +- Load it using the Catalog Browser + +## Pharo 4 + +- Open a Playground and evaluate: + +```smalltalk +Metacello new + baseline: 'RenoirSt'; + repository: 'github://ba-st/RenoirSt:stable-pharo-40/source'; + load +``` + +or + +- Load it using the Configuration Browser + +## Pharo 3 (this version is stalled at 1.4.0) + +- Load it using the Configuration Browser + +or + +- Open a workspace and evaluate: + +```smalltalk +Gofer it + url: 'http://smalltalkhub.com/mc/gcotelli/RenoirSt/main'; + configurationOf: 'RenoirSt'; + loadStable +``` diff --git a/docs/how-to/how-to-use-as-dependency-in-pharo.md b/docs/how-to/how-to-use-as-dependency-in-pharo.md new file mode 100644 index 0000000..baf3279 --- /dev/null +++ b/docs/how-to/how-to-use-as-dependency-in-pharo.md @@ -0,0 +1,42 @@ +# How to use RenoirSt as dependency in a Pharo product + +In order to include **RenoirSt** as part of your project, you should reference +the package in your product baseline: + +1. Define the RenoirSt repository and version to be used, and the [baseline groups](../reference/Baseline-groups.md) + you want to depend on (usually it will be `Deployment`). + + If you're unsure on what to depend use the *Dependency Analyzer* + tool to choose an appropriate group including the packages you need. + +2. Create a method like this one in the baseline class of your product: + + ```smalltalk + setUpDependencies: spec + + spec + baseline: 'RenoirSt' + with: [ spec repository: 'github://github://ba-st/RenoirSt:v{XX}' ]; + project: 'RenoirSt-Deployment' + copyFrom: 'RenoirSt' with: [ spec loads: 'Deployment' ] + ``` + + This will create `RenoirSt-Deployment` as a valid target that can be used + as requirement in your own packages. + + > Replace `{XX}` with the version you want to depend on + +3. Use the new loading target as a requirement on your packages. For example: + + ```smalltalk + baseline: spec + + + spec + for: #pharo + do: [ + self setUpDependencies: spec. + spec + package: 'My-Package' + with: [ spec requires: #('RenoirSt-Deployment') ] ] + ``` diff --git a/docs/reference/Baseline-groups.md b/docs/reference/Baseline-groups.md new file mode 100644 index 0000000..682f97a --- /dev/null +++ b/docs/reference/Baseline-groups.md @@ -0,0 +1,16 @@ +# Baseline Groups + +RenoirSt includes the following groups in its Baseline that can be used as +loading targets: + +- `Deployment` will load all the packages needed in a deployed application +- `Tests` will load the test cases +- `Tools` will load the extensions to the SUnit framework and development tools + (inspector and spotter extensions) +- `CI` is the group loaded in the continuous integration setup +- `Development` will load all the needed packages to develop and contribute to + the project +- `Deployment-Seaside-Extensions` will load all the packages needed in a deployed + application including the Javascript extensions +- `Development-Seaside-Extensions` will load all the needed packages to develop + and contribute to the project including the Javascript extensions diff --git a/docs/tutorial/Tutorial-Part-I.md b/docs/tutorial/Tutorial-Part-I.md index 2d4fef1..eee466b 100644 --- a/docs/tutorial/Tutorial-Part-I.md +++ b/docs/tutorial/Tutorial-Part-I.md @@ -2,7 +2,7 @@ ## Introduction -This tutorial asumes some knowledge of CSS and Pharo Smalltalk. +This tutorial assumes some knowledge of CSS and Pharo Smalltalk. The main entry point for the library is the class `CascadingStyleSheetBuilder`. Let's see some minimalist example. Copy the following in a workspace and @@ -12,7 +12,7 @@ Let's see some minimalist example. Copy the following in a workspace and CascadingStyleSheetBuilder new build ``` -Beautiful! You have now an inspector on your fisrt (empty and useless) style +Beautiful! You have now an inspector on your first (empty and useless) style sheet. Let's do something more useful now. Real stylesheets are composed of rules (or rule-sets), where each has a selector and a declaration group. The selector determines if the rule applies to some element in the DOM, and the @@ -70,7 +70,7 @@ time and frequency units in the CSS spec. There are extensions for `Integer` and - `vmin` 1% of viewport's smaller dimension - `vmax` 1% of viewport's larger dimension - `cm` centimeters -- `mm` millimeteres +- `mm` millimeters - `in` inches - `pc` picas - `pt` points @@ -432,7 +432,7 @@ commonly used for subtle shading in background images, buttons, and many other things. The gradient notations described in this section allow an author to specify such an image in a terse syntax, so that the UA can generate the image automatically when rendering the page. This notation is supported using -`CssLinearGradient` and `CssRadialGradient` asbtractions. +`CssLinearGradient` and `CssRadialGradient` abstractions. Let's see some examples for linear gradients: @@ -768,7 +768,7 @@ div } ``` -##### Aditional Functions for Transformation +##### Additional Functions for Transformation ###### Perspective @@ -991,4 +991,4 @@ renders as: 64px 64px 12px 40px black, inset 12px 11px 0px 8px black ``` -[Go to next chapter](Tutorial - Part II.md) +[Go to next chapter](Tutorial-Part-II.md) diff --git a/docs/tutorial/Tutorial-Part-II.md b/docs/tutorial/Tutorial-Part-II.md index d7a8317..9879633 100644 --- a/docs/tutorial/Tutorial-Part-II.md +++ b/docs/tutorial/Tutorial-Part-II.md @@ -4,7 +4,7 @@ So far our focus was on the *style* part of the rule. Let's focus now on the available *selectors*. Remember that a CSS selector represents a structure used -to match elements in the document tree. This chapter asume some familiarity with +to match elements in the document tree. This chapter assume some familiarity with the CSS selectors and will not go in detail about the exact meaning of each one. For more details you can take a look at . @@ -429,7 +429,7 @@ Some examples: 3 n + 1 "Prints as: 3n+1" ``` -The rest of the selectors in this category are modeled using the following messsages: +The rest of the selectors in this category are modeled using the following messages: - `nth-last-child()` -> `childFromLastAt:` - `nth-of-type()` -> `siblingOfTypeAt:` @@ -539,4 +539,4 @@ p.note::before } ``` -[Go to next chapter](Tutorial - Part III.md) +[Go to next chapter](Tutorial-Part-III.md) diff --git a/docs/tutorial/Tutorial-Part-III.md b/docs/tutorial/Tutorial-Part-III.md index 87cadb9..3910c5b 100644 --- a/docs/tutorial/Tutorial-Part-III.md +++ b/docs/tutorial/Tutorial-Part-III.md @@ -242,7 +242,7 @@ The following media feature messages are supported: - Accepting a `CssMeasure` with length units - `width:` - `minWidth:` - - `maxWidht:` + - `maxWidth:` - `height:` - `minHeight:` - `maxHeight:` diff --git a/source/BaselineOfRenoirSt/BaselineOfRenoirSt.class.st b/source/BaselineOfRenoirSt/BaselineOfRenoirSt.class.st index bc30e02..0f1ddbf 100644 --- a/source/BaselineOfRenoirSt/BaselineOfRenoirSt.class.st +++ b/source/BaselineOfRenoirSt/BaselineOfRenoirSt.class.st @@ -42,7 +42,7 @@ BaselineOfRenoirSt >> projectClass [ BaselineOfRenoirSt >> setUpDependencies: spec [ spec - baseline: 'Buoy' with: [ spec repository: 'github://ba-st/Buoy:v6/source' ]; + baseline: 'Buoy' with: [ spec repository: 'github://ba-st/Buoy:v6' ]; project: 'Buoy-Deployment' copyFrom: 'Buoy' with: [ spec loads: 'Deployment' ]; project: 'Buoy-SUnit' copyFrom: 'Buoy' with: [ spec loads: 'Dependent-SUnit-Extensions' ]; project: 'Buoy-Tools' copyFrom: 'Buoy' with: [ spec loads: 'Tools' ]. diff --git a/source/RenoirSt-Core/CssBoxShadow.class.st b/source/RenoirSt-Core/CssBoxShadow.class.st index 1c38828..2313fab 100644 --- a/source/RenoirSt-Core/CssBoxShadow.class.st +++ b/source/RenoirSt-Core/CssBoxShadow.class.st @@ -1,5 +1,5 @@ " -I represent a box shadow propery value. See http://www.w3.org/TR/css3-background/#box-shadow. +I represent a box shadow property value. See http://www.w3.org/TR/css3-background/#box-shadow. " Class { #name : #CssBoxShadow, diff --git a/source/RenoirSt-Core/CssColorStop.class.st b/source/RenoirSt-Core/CssColorStop.class.st index 174d9c1..d8415c5 100644 --- a/source/RenoirSt-Core/CssColorStop.class.st +++ b/source/RenoirSt-Core/CssColorStop.class.st @@ -13,9 +13,9 @@ Class { } { #category : #'Instance Creation' } -CssColorStop class >> for: aCssColor at: aLenght [ +CssColorStop class >> for: aCssColor at: aLength [ - ^ self new initializeFor: (self lookupColor: aCssColor) at: aLenght + ^ self new initializeFor: (self lookupColor: aCssColor) at: aLength ] { #category : #Printing } @@ -27,7 +27,7 @@ CssColorStop >> cssContentOn: aWriteStream [ ] { #category : #'initialize-release' } -CssColorStop >> initializeFor: aCssColor at: aLenght [ +CssColorStop >> initializeFor: aCssColor at: aLength [ color := aCssColor. - stop := aLenght + stop := aLength ] diff --git a/source/RenoirSt-Core/CssMediaQueryRuleBuilder.class.st b/source/RenoirSt-Core/CssMediaQueryRuleBuilder.class.st index 406cd0a..a7d6ee8 100644 --- a/source/RenoirSt-Core/CssMediaQueryRuleBuilder.class.st +++ b/source/RenoirSt-Core/CssMediaQueryRuleBuilder.class.st @@ -44,15 +44,15 @@ CssMediaQueryRuleBuilder >> colorIndex: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> deviceHeight: aCssLenght [ +CssMediaQueryRuleBuilder >> deviceHeight: aCssLength [ - self addExpressionForFeatureNamed: 'device-height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'device-height' withValue: aCssLength ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> deviceWidth: aCssLenght [ +CssMediaQueryRuleBuilder >> deviceWidth: aCssLength [ - self addExpressionForFeatureNamed: 'device-width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'device-width' withValue: aCssLength ] { #category : #'Configuring - Features' } @@ -62,9 +62,9 @@ CssMediaQueryRuleBuilder >> grid: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> height: aCssLenght [ +CssMediaQueryRuleBuilder >> height: aCssLength [ - self addExpressionForFeatureNamed: 'height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'height' withValue: aCssLength ] { #category : #'initialize-release' } @@ -95,21 +95,21 @@ CssMediaQueryRuleBuilder >> maxColorIndex: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> maxDeviceHeight: aCssLenght [ +CssMediaQueryRuleBuilder >> maxDeviceHeight: aCssLength [ - self addExpressionForFeatureNamed: 'max-device-height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'max-device-height' withValue: aCssLength ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> maxDeviceWidth: aCssLenght [ +CssMediaQueryRuleBuilder >> maxDeviceWidth: aCssLength [ - self addExpressionForFeatureNamed: 'max-device-width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'max-device-width' withValue: aCssLength ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> maxHeight: aCssLenght [ +CssMediaQueryRuleBuilder >> maxHeight: aCssLength [ - self addExpressionForFeatureNamed: 'max-height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'max-height' withValue: aCssLength ] { #category : #'Configuring - Features' } @@ -119,9 +119,9 @@ CssMediaQueryRuleBuilder >> maxMonochrome: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> maxWidth: aCssLenght [ +CssMediaQueryRuleBuilder >> maxWidth: aCssLength [ - self addExpressionForFeatureNamed: 'max-width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'max-width' withValue: aCssLength ] { #category : #'Configuring - Features' } @@ -143,21 +143,21 @@ CssMediaQueryRuleBuilder >> minColorIndex: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> minDeviceHeight: aCssLenght [ +CssMediaQueryRuleBuilder >> minDeviceHeight: aCssLength [ - self addExpressionForFeatureNamed: 'min-device-height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'min-device-height' withValue: aCssLength ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> minDeviceWidth: aCssLenght [ +CssMediaQueryRuleBuilder >> minDeviceWidth: aCssLength [ - self addExpressionForFeatureNamed: 'min-device-width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'min-device-width' withValue: aCssLength ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> minHeight: aCssLenght [ +CssMediaQueryRuleBuilder >> minHeight: aCssLength [ - self addExpressionForFeatureNamed: 'min-height' withValue: aCssLenght + self addExpressionForFeatureNamed: 'min-height' withValue: aCssLength ] { #category : #'Configuring - Features' } @@ -167,9 +167,9 @@ CssMediaQueryRuleBuilder >> minMonochrome: anInteger [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> minWidth: aCssLenght [ +CssMediaQueryRuleBuilder >> minWidth: aCssLength [ - self addExpressionForFeatureNamed: 'min-width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'min-width' withValue: aCssLength ] { #category : #'Configuring - Features' } @@ -209,7 +209,7 @@ CssMediaQueryRuleBuilder >> useStyleSheet: aCascadingStyleSheet [ ] { #category : #'Configuring - Features' } -CssMediaQueryRuleBuilder >> width: aCssLenght [ +CssMediaQueryRuleBuilder >> width: aCssLength [ - self addExpressionForFeatureNamed: 'width' withValue: aCssLenght + self addExpressionForFeatureNamed: 'width' withValue: aCssLength ] diff --git a/source/RenoirSt-HTML-Tests/CssHTMLTypeSelectorTest.class.st b/source/RenoirSt-HTML-Tests/CssHTMLTypeSelectorTest.class.st index 9788eed..d8e476e 100644 --- a/source/RenoirSt-HTML-Tests/CssHTMLTypeSelectorTest.class.st +++ b/source/RenoirSt-HTML-Tests/CssHTMLTypeSelectorTest.class.st @@ -1,5 +1,5 @@ " -A CssHTMLTypeSelectorTest is a Test case for HTMLtype extentions to CssSelectors +A CssHTMLTypeSelectorTest is a Test case for HTMLtype extensions to CssSelectors " Class { diff --git a/source/RenoirSt-Tests/CssAdjacentSiblingCombinatorTest.class.st b/source/RenoirSt-Tests/CssAdjacentSiblingCombinatorTest.class.st index 62964d0..533946b 100644 --- a/source/RenoirSt-Tests/CssAdjacentSiblingCombinatorTest.class.st +++ b/source/RenoirSt-Tests/CssAdjacentSiblingCombinatorTest.class.st @@ -21,10 +21,10 @@ CssAdjacentSiblingCombinatorTest >> testBuildingShortcut [ { #category : #Tests } CssAdjacentSiblingCombinatorTest >> testPrintString [ - | predecessor sucessor | + | predecessor successor | predecessor := CssUniversalSelector implicit class: 'custom'. - sucessor := CssTypeSelector ofType: 'div'. + successor := CssTypeSelector ofType: 'div'. - self assert: (CssAdjacentSiblingCombinator between: predecessor and: sucessor) printString equals: '.custom + div' + self assert: (CssAdjacentSiblingCombinator between: predecessor and: successor) printString equals: '.custom + div' ] diff --git a/source/RenoirSt-Tests/CssGeneralSiblingCombinatorTest.class.st b/source/RenoirSt-Tests/CssGeneralSiblingCombinatorTest.class.st index 26def32..378d77b 100644 --- a/source/RenoirSt-Tests/CssGeneralSiblingCombinatorTest.class.st +++ b/source/RenoirSt-Tests/CssGeneralSiblingCombinatorTest.class.st @@ -21,10 +21,10 @@ CssGeneralSiblingCombinatorTest >> testBuildingShortcut [ { #category : #Tests } CssGeneralSiblingCombinatorTest >> testPrintString [ - | predecessor sucessor | + | predecessor successor | predecessor := CssUniversalSelector implicit class: 'custom'. - sucessor := CssTypeSelector ofType: 'div'. + successor := CssTypeSelector ofType: 'div'. - self assert: (CssGeneralSiblingCombinator between: predecessor and: sucessor) printString equals: '.custom ~ div' + self assert: (CssGeneralSiblingCombinator between: predecessor and: successor) printString equals: '.custom ~ div' ] diff --git a/source/RenoirSt-Tests/CssUnitTest.class.st b/source/RenoirSt-Tests/CssUnitTest.class.st index 55e64ca..509e662 100644 --- a/source/RenoirSt-Tests/CssUnitTest.class.st +++ b/source/RenoirSt-Tests/CssUnitTest.class.st @@ -1,5 +1,5 @@ " -A CssLenghtUnitTest is a test class for testing the behavior of CssLenghtUnit +A CssUnitTest is a test class for testing the behavior of CssUnit " Class { #name : #CssUnitTest,