Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark custom assertion methods with SonarSource attribute #227

Closed
egil opened this issue Oct 5, 2020 · 0 comments · Fixed by #229
Closed

Mark custom assertion methods with SonarSource attribute #227

egil opened this issue Oct 5, 2020 · 0 comments · Fixed by #229
Assignees
@egil
Labels
enhancement New feature or request good first issue Good for newcomers input needed When an issue requires input or suggestions

Comments

@egil
Copy link
Member

egil commented Oct 5, 2020

The MarkupMatches methods needs to be marked as assertion methods to avoid SonarSource complaining.

Details: https://jira.sonarsource.com/browse/RSPEC-3413
Background: #216
@egil egil added enhancement New feature or request good first issue Good for newcomers input needed When an issue requires input or suggestions labels Oct 5, 2020
@egil egil linked a pull request Oct 7, 2020 that will close this issue
feature/227 assertionmethod #229
Merged
@egil egil mentioned this issue Oct 7, 2020
Merged
@egil egil self-assigned this Oct 7, 2020
@egil egil closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egil egil

Labels
enhancement New feature or request good first issue Good for newcomers input needed When an issue requires input or suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature/227 assertionmethod bUnit-dev/bUnit
1 participant
@egil