Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about addon handling categories without recipes #99

Open
Wraithlord2015 opened this issue Sep 22, 2024 · 5 comments
Open

Question about addon handling categories without recipes #99

Wraithlord2015 opened this issue Sep 22, 2024 · 5 comments

Comments

@Wraithlord2015
Copy link

Per our short conversation on curseforge about "Draenor Mining" and "Shadowlands Mining" being returned by Blizzards API as a "subheader" and not a "header", is there a way to work around this so the addon shows the skill level like all the others?

@b-morgan
Copy link
Owner

I'll have to do some research to see if I can generate some "fake" data. These two mining categories have no recipes so other than keeping track of the skill level, there's nothing for Skillet to "craft" in these categories. I'll update this issue if I have any success.

You can open the Blizzard Mining UI by shift-clicking your action bar button and the dropdown at the top will list your skill levels for these two categories. Other addons like Altoholic and BagSync will also list them.

I have two toons with mining, a Blacksmith and a Jewelcrafter. Turns out my Jewelcrafter skipped Shadowlands so he never trained there.

@Wraithlord2015
Copy link
Author

Wraithlord2015 commented Sep 22, 2024

Sure thing. If it's not possible - at least you gave it your best shot. Tks for looking into it either way! :)

PS - that's all I'm looking for; is to just be able to track the skill level like the others. I prefer your addon's interface, and I like to be able to (at a glance) see if I'm missing training from any of the expansions and where I'm at skill wise. Not sure why, but Blizz's interface just feels really cluttered to me.

@b-morgan
Copy link
Owner

Many of Skillet's databases are keyed by recipeID. The data for each recipe includes the category, subcategory, etc. Since these two categories don't have any recipes, they are never seen by Skillet. I believe to change this behavior will require substantial work.

I've still got some investigating to do.

@b-morgan b-morgan changed the title Question about addon handling of "subheader" and "header" Question about addon handling categories without recipes Sep 24, 2024
@Wraithlord2015
Copy link
Author

Is it possible to have it display a message along the lines of "Blizzard did not add in any recipes for this expansion" and have it display the skill level?

@b-morgan
Copy link
Owner

b-morgan commented Oct 1, 2024

If I could display a message I could just display the progress bar. As I've said before, Skillet's database is indexed by recipes and since these categories have no recipes, Skillet doesn't "see" the categories. I wish I could solve this problem but it would need a major rewrite of Skillet's data gathering logic.

I could do something like the Altoholic display below, but I'm not sure that it is worth the effort.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants