Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to create multiple rumble favourite instances for same channel #40

Open
Pi-MONSTER opened this issue Aug 2, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Pi-MONSTER
Copy link

Pi-MONSTER commented Aug 2, 2024

Saving a channel which already is a rumble favourite results in a new favourite if the subscriber count has changed.

ie. for the popular channel "mylunchbreak" I have been able to create the following working favourites;

"[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]7,989[/COLOR] [COLOR yellow]Subscribers[/COLOR]"
"[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]13,420[/COLOR] [COLOR yellow]Subscribers[/COLOR]"
"[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]14,092[/COLOR] [COLOR yellow]Subscribers[/COLOR]"
"[B]MYLUNCHBREAK CHANNEL PAGE[/B]\n[COLOR palegreen]15,614[/COLOR] [COLOR yellow]Subscribers[/COLOR]"

I think there are more code lines doing this but the following two illustrate the effect

line 283
add_dir( video_title, BASE_URL + link, 4, images, info_labels, cat, False, True, play, { 'name' : channel_link, 'subscribe': True } )

line 444
video_title += '[COLOR palegreen]' + subscribers + '[/COLOR] [COLOR yellow]' + get_string(30156) + '[/COLOR]'

Just a minor problem I noticed.

Would also be nice if there was a way to easily edit the order of favourites.

@azzy9 azzy9 added the bug Something isn't working label Aug 2, 2024
@azzy9
Copy link
Owner

azzy9 commented Aug 2, 2024

Aye, favourites needs to be reworked as there is no unique identifier for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants