Fix ModuleIdentityDelete (service returns 204, not 200) (#34)

* On the management API, delete identities response should be status="204" Server is correct, so I will update edgeAgent and the YAML file. * Discovered a problem with runtime info and GA (1.0.0) iotedged
Azure · Jul 18, 2018 · 2163103 · 2163103
1 parent f2baacf
commit 2163103
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Edgelet/generatedCode/EdgeletHttpClient.cs b/edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Edgelet/generatedCode/EdgeletHttpClient.cs
@@ -1336,7 +1336,7 @@ public async System.Threading.Tasks.Task DeleteIdentityAsync(string api_version,
                         ProcessResponse(client_, response_);
 
                         var status_ = ((int)response_.StatusCode).ToString();
-                        if (status_ == "200")
+                        if (status_ == "200" || status_ == "204")
                         {
                             return;
                         }
@@ -1450,7 +1450,7 @@ public string Architecture
             }
         }
 
-        [Newtonsoft.Json.JsonProperty("version", Required = Newtonsoft.Json.Required.Always)]
+        [Newtonsoft.Json.JsonProperty("version", Required = Newtonsoft.Json.Required.DisallowNull)]
         public string Version
         {
             get { return _version; }

diff --git a/edgelet/api/management.yaml b/edgelet/api/management.yaml
@@ -369,7 +369,7 @@ paths:
           required: true
           type: string
       responses:
-        '200':
+        '204':
           description: Ok
         '404':
           description: Not Found
@@ -530,7 +530,6 @@ definitions:
     required:
       - osType
       - architecture
-      - version
     example:
       osType: "linux/windows"
       architecture: "arm/amd64/x86"