Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl2: Make New return an interface instead. #107

Closed
azul3d-bot opened this issue Mar 6, 2016 · 2 comments
Closed

gl2: Make New return an interface instead. #107

azul3d-bot opened this issue Mar 6, 2016 · 2 comments

Comments

@azul3d-bot
Copy link

Issue by slimsag
Wednesday Nov 26, 2014 at 01:25 GMT
Originally opened as azul3d-legacy/gfx#52


If you look at the docs for the gfx/gl2 package: https://godoc.org/azul3d.org/gfx/gl2.v2

Majority of the methods defined on gl2.Renderer are simply implementing the gfx.Renderer interface. It's hard to tell from the docs which ones are not part of gfx.Renderer -- a better solution would be to make gl2.Renderer a interface:

type Renderer interface {
    gfx.Renderer
    // Other OpenGL 2 specific renderer things.
}
@azul3d-bot
Copy link
Author

Comment by slimsag
Wednesday Nov 26, 2014 at 01:58 GMT


After:

gl2-after

Before:

gl2-before

@slimsag
Copy link
Member

slimsag commented Mar 6, 2016

Fixed/merged as part of #1

@slimsag slimsag closed this as completed Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants