update d.ts for ts2.6 breaking change #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Nov 15, 2017
src/index.d.ts
Outdated
| @@ -12,5 +11,15 @@ export class UIEventObserver { | |||
|
|
|||
| unsubscribeAll(): void; | |||
| } | |||
| export default new UIEventObserver(); | |||
| declare module default_ { | |||
There was a problem hiding this comment.
ui-event-observer/src/index.js
Line 6 in 3483dad
であるため、default_ は UIEventObserver にしたいです。
azu
requested changes
Nov 15, 2017
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "src/" | |||
| ], | |||
| "name": "ui-event-observer", | |||
| "version": "1.2.1", | |||
| "version": "1.2.2", | |||
* version update is not required * rename sxported module name
|
@fukken Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#arbitrary-expressions-are-forbidden-in-export-assignments-in-ambient-contexts
declaration files に任意の式を書けていたのが、2.6で書けなくなるため、 declare などに置き換えます。
dts-gen で生成すると、prototypeが二重定義になっている、と怒られるため、手書きしました。
過去のバージョンのtsでも問題なく動くのではないかと思いますが、2.6以外での確認はしていません。