From abd2d66e60bf9d0357f4fc4039d56115697e398a Mon Sep 17 00:00:00 2001
From: Azriel Hoh <azriel91@gmail.com>
Date: Tue, 28 Feb 2023 14:59:05 +1300
Subject: [PATCH] Disable clippy CI job.

Due to https://github.com/clap-rs/clap/issues/4733 not fully fixed.
---
 .github/workflows/ci.yml | 97 +++++++++++++++++++++-------------------
 1 file changed, 50 insertions(+), 47 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e65bb424b..a8b02a1b0 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -85,53 +85,56 @@ jobs:
           command: doc
           args: --no-deps
 
-  clippy:
-    name: Clippy
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    steps:
-      - uses: actions/checkout@v3
-      - # FIXME: Switch back when actions-rs/toolchain#{209,220,222} is merged
-        uses: r3-os/actions-rust-toolchain@a862b6623c178b43a3135516442a5f72fb5c1877
-        with:
-          profile: minimal
-          toolchain: nightly
-          override: true
-          components: clippy
-
-      - name: 'Run clippy'
-        run: |
-          cargo clippy \
-            --workspace \
-            --all-features \
-            --fix \
-            --exclude peace_rt_model_web \
-            -- -D warnings
-
-        # Ideally we'd also run it for WASM, but:
-        #
-        # * `workspace_tests` is only coded for native targets.
-        # * There is little benefit running it for everything again.
-        #
-        # The command that we *would* use is:
-        #
-        # ```bash
-        # cargo clippy \
-        #   --workspace \
-        #   --target wasm32-unknown-unknown \
-        #   --no-default-features \
-        #   --features "error_reporting output_colorized output_json" \
-        #   --fix \
-        #   --exclude peace_rt_model_native \
-        #   --exclude peace_item_spec_sh_cmd \
-        #   --exclude peace_item_spec_sh_sync_cmd \
-        #   --exclude peace_item_spec_tar_x \
-        #   --exclude peace_item_specs \
-        #   --exclude workspace_tests \
-        #   --exclude app_cycle \
-        #   --exclude download \
-        #   -- -D warnings
-        # ```
+  # Disabled due to:
+  # <https://github.com/clap-rs/clap/issues/4733>
+  #
+  # clippy:
+  #   name: Clippy
+  #   runs-on: ubuntu-latest
+  #   timeout-minutes: 10
+  #   steps:
+  #     - uses: actions/checkout@v3
+  #     - # FIXME: Switch back when actions-rs/toolchain#{209,220,222} is merged
+  #       uses: r3-os/actions-rust-toolchain@a862b6623c178b43a3135516442a5f72fb5c1877
+  #       with:
+  #         profile: minimal
+  #         toolchain: nightly
+  #         override: true
+  #         components: clippy
+  #
+  #     - name: 'Run clippy'
+  #       run: |
+  #         cargo clippy \
+  #           --workspace \
+  #           --all-features \
+  #           --fix \
+  #           --exclude peace_rt_model_web \
+  #           -- -D warnings
+  #
+  #       # Ideally we'd also run it for WASM, but:
+  #       #
+  #       # * `workspace_tests` is only coded for native targets.
+  #       # * There is little benefit running it for everything again.
+  #       #
+  #       # The command that we *would* use is:
+  #       #
+  #       # ```bash
+  #       # cargo clippy \
+  #       #   --workspace \
+  #       #   --target wasm32-unknown-unknown \
+  #       #   --no-default-features \
+  #       #   --features "error_reporting output_colorized output_json" \
+  #       #   --fix \
+  #       #   --exclude peace_rt_model_native \
+  #       #   --exclude peace_item_spec_sh_cmd \
+  #       #   --exclude peace_item_spec_sh_sync_cmd \
+  #       #   --exclude peace_item_spec_tar_x \
+  #       #   --exclude peace_item_specs \
+  #       #   --exclude workspace_tests \
+  #       #   --exclude app_cycle \
+  #       #   --exclude download \
+  #       #   -- -D warnings
+  #       # ```
 
   coverage:
     name: Coverage