Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Task Bullets #123

Closed
l4ci opened this issue Jan 21, 2014 · 4 comments
Closed

Additional Task Bullets #123

l4ci opened this issue Jan 21, 2014 · 4 comments

Comments

@l4ci
Copy link

l4ci commented Jan 21, 2014

Hey there, love the plugin so far, but can you add some additional bullet options?

I'd love to use:

"open_tasks_bullet": "[ ]", 
"done_tasks_bullet": "[x]", 
"cancelled_tasks_bullet": "[-]", 

which works basically - but only to some extend: tags seem to be broken with it, so thats why I guess you show us the options we can use as bullets.

Just a small addition ;)

@vovkkk
Copy link
Collaborator

vovkkk commented Jan 21, 2014

The main point of bullets (or rather the fact that one has to use only specific bullets) is that syntax highlighting in ST happens due regexes.
You cannot just put arbitrary character, especially if that character is already in use.
So namely

  1. Whitespace is used for indentation, and if line has no leading bullet character it'll be consider as a note. I.e. we can’t use it as bullet unless we decide to eliminate the difference between pending task and note (for me personally it’s no-no).
  2. x is used for cancelled tasks, we probably could make it work due tags, but since it’s possible to use PT w/o done tags at all and the fact that we already added similar functionality (I mean same bullet for different types) for TaskPaper support, it seems questionably (I don’t see a reason to increase complexity of regexes which are already quite complex).
  3. Same as 2.

BTW, in case you’re wondering highlighting is not only ‘fancy colours’, it is more, e.g. currently notes are archiving just by the fact that they are notes… um… I mean, if you look at the script you’ll see that code checks the scope of the line and scope comes from highlighting. In fact, I’m going only increase the use of scopes in script, for instance it’ll be useful to make acceptable multiple bullet types at the same time (currently PT become confuse if bullet in document and in settings are different) and maybe something else, so it’s important to keep scopes solid stable.

@vovkkk vovkkk closed this as completed Jan 21, 2014
@l4ci
Copy link
Author

l4ci commented Jan 21, 2014

Ah okay, I understand. Thanks for explaining 👍

@vovkkk
Copy link
Collaborator

vovkkk commented Jan 21, 2014

Sorry, I’m silly, initially I’ve missed square brackets, so actually these bullets can be added w/o problems.
Man, never send message before you finish your coffee.

So it’s orgmode style, right? and GitHub markdown supports these, yea let’s add them.

@vovkkk vovkkk reopened this Jan 21, 2014
@l4ci
Copy link
Author

l4ci commented Jan 21, 2014

haha, happens ;) yea github todos work that way - awesome!

@vovkkk vovkkk closed this as completed in a83fe56 Jan 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants