Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (CI): add ready_for_review to pull request types filter #19085

Closed
sogladev opened this issue Jun 18, 2024 · 1 comment
Closed

Feature (CI): add ready_for_review to pull request types filter #19085

sogladev opened this issue Jun 18, 2024 · 1 comment

Comments

@sogladev
Copy link
Member

Describe your feature request or suggestion in detail

Setting PR status from draft to ready for review does not trigger builds. closing/opening or adding a useless commit is /can be used as a workaround.

official docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

Describe a possible solution to your feature or suggestion in detail

Add ready_for_review to pull request types filter like below to the files listed below

pull_request:
    branches: [my_branch]
    types:
      - opened
      - reopened
      - synchronize
      - ready_for_review

https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/core-build-nopch.yml
https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/core-build-pch.yml
https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/core_modules_build.yml
https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/docker_build.yml
https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/macos_build.yml
https://github.com/azerothcore/azerothcore-wotlk/blob/master/.github/workflows/windows_build.yml

Additional context

No response

@Kitzunu
Copy link
Member

Kitzunu commented Dec 29, 2024

this is fixed

@Kitzunu Kitzunu closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants