-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pagination more generic and not Franklin specific #413
Make pagination more generic and not Franklin specific #413
Conversation
4b0df4c
to
9074f4c
Compare
9d9d405
to
37ea65f
Compare
@@ -151,20 +149,48 @@ case class SttpStacClientF[F[_]: MonadThrow, S: Lens[*, Option[PaginationToken]] | |||
} | |||
|
|||
object SttpStacClientF { | |||
// TODO: should be a newtype | |||
type PaginationToken = NonEmptyString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is probably not a part of this PR and could be a more broad discussion. Good for now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, I think this is fine -- we don't really know anything about "semantics" of a pagination token, it might not even be a non-empty string in some cases. We should revisit if this becomes insufficient but I think this is pretty much all we know about pagination tokens right now
4c5613a
to
a05c99f
Compare
a05c99f
to
0468782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this -- I think when we were talking about pagination originally I wanted stac4s to treat the token as completely opaque, but we went with copy-pasta instead to unblock ourselves, so I'm happy this is getting genericized
Overview
This PR makes pagination more generic and not Franklin specific.
Checklist
chan
)Closes #409
Closes #410
Closes #411