Lines in first write of combat log file are ignored

[aza547]

Theory is this:

• We currently poll for new files by listing the directory.
• When we spot new files we start tailing them for new writes.
• That means that the first write to a file is never processed.
• If that write contains a CHALLENGE_MODE_START event for example, we fail to record an entire key.

Surely the fix is to read any existing content in a newly spotted combat log file before we start tailing.

[aza547]

Reproduced by dropping this bit from the test scripts:

# If ARENA_MATCH_START is the first line we don't start recording 
# but this never happens in reality so just write a line. 
logFile.write("This is a test line to create the file\n")
time.sleep(2)

[aza547]

A user reported this, here's some logs (see the final DHT):

WarcraftRecorder-2023-11-19 (3).log

The top of the combat log file:

11/19 13:35:47.818 COMBAT_LOG_VERSION,20,ADVANCED_LOG_ENABLED,1,BUILD_VERSION,10.2.0,PROJECT_ID,1
11/19 13:35:47.819 CHALLENGE_MODE_END,1466,0,0,0,0.000000,0.000000
11/19 13:35:47.818 ZONE_CHANGE,1466,"Darkheart Thicket",8
11/19 13:35:47.818 MAP_CHANGE,733,"Darkheart Thicket",3354.169922,2604.169922,2241.669922,1116.670044
11/19 13:35:47.820 SPELL_AURA_REMOVED,Player-55-0995A773,"Royalkush-Whisperwind",0x511,0x1,Pet-0-4229-1220-24146-165189-0104463697,"Sul'raka",0x1112,0x0,465,"Devotion Aura",0x2,BUFF
11/19 13:35:47.821 SPELL_AURA_REMOVED,Player-55-0995A773,"Royalkush-Whisperwind",0x511,0x1,Pet-0-4218-1466-25986-165189-0103D9517B,"Fenyr",0x1112,0x0,465,"Devotion Aura",0x2,BUFF
11/19 13:35:47.821 SPELL_AURA_REMOVED,Player-55-0995A773,"Royalkush-Whisperwind",0x511,0x1,Pet-0-4218-1466-25986-165189-0103F0B185,"Terrorpene",0x1112,0x0,465,"Devotion Aura",0x2,BUFF
11/19 13:35:47.821 SPELL_AURA_REMOVED,Player-55-0995A773,"Royalkush-Whisperwind",0x511,0x1,Pet-0-4229-1220-24146-165189-0104463544,"Sul'raka",0x1112,0x0,465,"Devotion Aura",0x2,BUFF
11/19 13:35:47.907 CHALLENGE_MODE_START,"Darkheart Thicket",1466,198,18,[10,136,8]

[aza547]

[aza547]

This is merged to main now under 4a7f6a8. I've done some testing and seems OK so far. We've lost the locking of a combat log, but I think that's fine. Bit nervous about multi-box confusion but I'm going to state that's not supported.