Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mythic+ adding combatants that come from other events than COMBATANT_INFO #368

Closed
aza547 opened this issue Apr 9, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Apr 9, 2023

{
  "category": "Mythic+",
  "zoneID": 1477,
  "mapID": 200,
  "duration": 891.828,
  "result": true,
  "upgradeLevel": 0,
  "player": {
    "_GUID": "Player-57-0B2EABFD",
    "_name": "Shesappedme",
    "_realm": "Illidan"
  },
  "timeline": [
    {
      "segmentType": "Trash",
      "logStart": "2023-04-09T14:28:10.941Z",
      "timestamp": 0,
      "logEnd": "2023-04-09T14:43:02.769Z"
    }
  ],
  "level": 23,
  "flavour": "Retail",
  "overrun": 5,
  "combatants": [
    {
      "_GUID": "Player-61-0EF570D1",
      "_teamID": 0,
      "_specID": 64,
      "_name": "Icelancealot",
      "_realm": "Zul'jin"
    },
    {
      "_GUID": "Player-162-0B306D93",
      "_teamID": 0,
      "_specID": 65,
      "_name": "Tenerok",
      "_realm": "EmeraldDream"
    },
    {
      "_GUID": "Player-73-0E873DCA",
      "_teamID": 0,
      "_specID": 104,
      "_name": "Herßie",
      "_realm": "BleedingHollow"
    },
    {
      "_GUID": "Player-3209-0A267299",
      "_teamID": 0,
      "_specID": 252,
      "_name": "Crows",
      "_realm": "Azralon"
    },
    {
      "_GUID": "Player-3693-0E13FE3B",
      "_teamID": 1,
      "_specID": 258,
      "_name": "Dunkarina",
      "_realm": "Kel'Thuzad"
    },
    {
      "_GUID": "Player-11-0BD1658B",
      "_name": "Yeena",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-11-0E52E3CC",
      "_name": "Qlbl",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-11-0E2459E3",
      "_name": "Lsswapped",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-11-0E48FE28",
      "_name": "Bubblenao",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-121-094F8FC6",
      "_name": "Baudrillard",
      "_realm": "Blackrock"
    },
    {
      "_GUID": "Player-11-0E52F50A",
      "_name": "Xid",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-57-0D7D14BB",
      "_name": "Hoodmage",
      "_realm": "Illidan"
    },
    {
      "_GUID": "Player-3676-0DF80A18",
      "_name": "Darthspyro",
      "_realm": "Area52"
    },
    {
      "_GUID": "Player-57-0B2EABFD",
      "_name": "Shesappedme",
      "_realm": "Illidan"
    },
    {
      "_GUID": "Player-11-0E536DDA",
      "_name": "Laureate",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-11-0B6B499E",
      "_name": "Bdvlmc",
      "_realm": "Tichondrius"
    },
    {
      "_GUID": "Player-60-0EE78969",
      "_name": "Keyrippa",
      "_realm": "Stormrage"
    }
  ]
}
@aza547 aza547 added the bug Something isn't working label Apr 9, 2023
@aza547
Copy link
Owner Author

aza547 commented Apr 9, 2023

This is the classic code / retail BG only code that parses SPELL_CAST_SUCCESS for Combatant info. We don't need that in any retail activities except BGs, so the fix is to stop calling that code.

@aza547
Copy link
Owner Author

aza547 commented Apr 9, 2023

fed0f3d

@aza547 aza547 closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant