Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signalling isn't robust enough #279

Closed
aza547 opened this issue Jan 8, 2023 · 1 comment · Fixed by #281
Closed

Signalling isn't robust enough #279

aza547 opened this issue Jan 8, 2023 · 1 comment · Fixed by #281
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Jan 8, 2023

I think we should convert the signalling checks from asserting we always get what we expect, to just handling whatever we see.

Streamlabs desktop does this.

Obviously we'll still throw an error if we get something totally unexpected, but too often we get signals like "got stop but expected stopping" - I don't know the cause for this but I'm sure it's fine and we shouldn't crash the app for it.

@aza547 aza547 added the bug Something isn't working label Jan 8, 2023
@aza547
Copy link
Owner Author

aza547 commented Jan 8, 2023

Example:
message (9).txt
message (8).txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant