Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with display scaling #123

Closed
Emme opened this issue Sep 19, 2022 · 5 comments
Closed

Problem with display scaling #123

Emme opened this issue Sep 19, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Emme
Copy link
Contributor

Emme commented Sep 19, 2022

Describe the bug
When using windows display scaling, the app can't find a matching output resolution:

[error] [OBS] ERROR! Matching resolution not found for Video Output
[error] Error attempting to match 3841.25x2161.25 with 1920x1080,1280x720,1920x1200,1200x1920,3840x2160 for Base

Expected behavior
The output resolution should be set to the closest matching one

Additional context
The log entry for the relevant monitor:

  {
    id: 2841568472,
    bounds: { x: 0, y: 0, width: 2195, height: 1235 },
    workArea: { x: 0, y: 0, width: 2195, height: 1195 },
    accelerometerSupport: 'unknown',
    monochrome: false,
    colorDepth: 24,
    colorSpace: '{primaries:BT709, transfer:SRGB, matrix:RGB, range:FULL}',
    depthPerComponent: 8,
    size: { width: 2195, height: 1235 },
    displayFrequency: 60,
    workAreaSize: { width: 2195, height: 1195 },
    scaleFactor: 1.75,
    rotation: 0,
    internal: false,
    touchSupport: 'unknown'
  }

WarcraftRecorder-2022-09-19.log
2022-09-19 19-29-11.txt

@aza547
Copy link
Owner

aza547 commented Sep 19, 2022

Interesting! Another user had trouble with the scaleFactor rounding. We made a fix in the last release to "snap" to a close resolution so long as the resolution was within 1 pixel. Here it's 1.25 pixels off so that snapping doesn't happen.

Easy fix that we should probably make is to make the snapping happen for a wider range (bumping it to 2 would fix it - but that might not solve for everyone...).

@aza547
Copy link
Owner

aza547 commented Sep 19, 2022

@Emme I'd like to make a fix and share a rebuilt version of the app for you to test. Sound OK?

@aza547 aza547 added the bug Something isn't working label Sep 19, 2022
@aza547
Copy link
Owner

aza547 commented Sep 19, 2022

@Emme
Copy link
Contributor Author

Emme commented Sep 19, 2022

Yes, it's working now.

@aza547
Copy link
Owner

aza547 commented Sep 19, 2022

Great. I'll mark this closed and will be fixed in 2.7.1 when it releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants