Skip to content
This repository has been archived by the owner on Aug 31, 2018. It is now read-only.

worker: restrict supported extensions #117

Closed
wants to merge 2 commits into from
Closed

worker: restrict supported extensions #117

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

worker

TimothyGu and others added 2 commits October 22, 2017 22:24
@TimothyGu @addaleax
worker: restrict supported extensions
caeacff 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.
@addaleax
test: add workers + ES Module test
7711dee
TimothyGu
TimothyGu approved these changes Oct 22, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should IMO be squashed into the main PR as well.

@addaleax
Copy link
Contributor Author

@TimothyGu I merged the main impl PR @ #110 so that most of the dependent bits of code can be unblocked.

Also, although the argument doesn’t really the case here, I like doing work in small chunks because it helps reviewers :)

@ghost
Copy link

ghost commented Oct 22, 2017

i agree with @addaleax, even though it's a lot of prs, it splits it up into manageable pieces pretty nicely!

addaleax pushed a commit that referenced this pull request Oct 24, 2017
@TimothyGu @addaleax
worker: restrict supported extensions
d934a8d 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

PR-URL: #117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit that referenced this pull request Oct 24, 2017
@addaleax
test: add workers + ES Module test
8ecabc1 
PR-URL: #117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@addaleax
Copy link
Contributor Author

Landed in d934a8d, 8ecabc1 :)

@addaleax addaleax closed this Oct 24, 2017
@addaleax addaleax deleted the restrict-extensions branch October 24, 2017 21:46
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
@addaleax
worker: initial implementation
545a873 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117
addaleax pushed a commit to addaleax/node that referenced this pull request Jun 5, 2018
@TimothyGu @addaleax
worker: restrict supported extensions
c080f8b 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

Refs: ayojs/ayo#117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
@addaleax
worker: initial implementation
0c7012e 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117
addaleax pushed a commit to addaleax/node that referenced this pull request Jun 5, 2018
@TimothyGu @addaleax
worker: restrict supported extensions
53b660b 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

Refs: ayojs/ayo#117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit to nodejs/node that referenced this pull request Jun 6, 2018
@addaleax
worker: initial implementation
0df031a 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
addaleax pushed a commit to nodejs/node that referenced this pull request Jun 6, 2018
@TimothyGu @addaleax
worker: restrict supported extensions
147ea5e 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

Refs: ayojs/ayo#117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 7, 2018
@addaleax @targos
worker: initial implementation
c47fcfa 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 7, 2018
@TimothyGu @targos
worker: restrict supported extensions
7d8ec1a 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

Refs: ayojs/ayo#117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 13, 2018
@addaleax @targos
worker: initial implementation
109c92e 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Jun 13, 2018
@TimothyGu @targos
worker: restrict supported extensions
c97fb91 
Only allow `.js` and `.mjs` extensions to provide future-proofing
for file type detection.

Refs: ayojs/ayo#117
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Olivia Hugger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #20876
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @Qard @TimothyGu