Extract aya-build for building eBPF crates #1101
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mergify
bot
added
aya-bpf
tamird
force-pushed
the
aya-build
branch
4 times, most recently
from
9d8b361 to
b90ee6f
Compare
aya-build/src/lib.rs
Outdated
| /// prevent their use for the time being. | ||
| /// | ||
| /// [bindeps]: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html?highlight=feature#artifact-dependencies | ||
| pub fn build_ebpf(packages: impl IntoIterator<Item = Package>) { |
There was a problem hiding this comment.
I would prefer returning an error instead of panicking (at least in places which actually can panic if the build fails).
I know that 99% of users will unwrap in build.rs anyways (that's fine and expected), but still, I would stick to the principle that libraries should return an error. There always might be that 1% of people who want to create some more sophisticated xtask and handle the error somehow.
There was a problem hiding this comment.
Will do. In the meantime can you review #1098 which is a prerequisite of this?
|
@tamird, this pull request is now in conflict and requires a rebase. |
|
needs a rebase and a bless |
We'll use this in the template and book to avoid duplicating all the code.
Something of an experiment.
Please ignore all but the last commit.
This change is