Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logic): ensure keepers in interpreter exec ctx #279

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

amimart
Copy link
Member

@amimart amimart commented Feb 4, 2023

This is a proposal to fix an issue related to the presence of the bank & account keepers in prolog interpreter executions.

It ensures those keepers are present in the sdk.Context once unwrapped. It introduce an helper func enhanceContext to prepare the context before execution in which new elements may be added in the future.

@amimart amimart requested review from ccamel and bdeneux February 4, 2023 21:07
@amimart amimart self-assigned this Feb 4, 2023
@amimart amimart marked this pull request as ready for review February 4, 2023 21:07
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! I was already fix this issue on another PR (#274) but you have made linter happy unlike me ^^.

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks 👍

@amimart amimart merged commit b65bf92 into main Feb 6, 2023
@amimart amimart deleted the fix/logic-exec-ctx branch February 6, 2023 08:00
@bot-anik
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bot-anik
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants