-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📌 Switch mocking library from golang/mock to go.uber.org/mock #770
Comments
Hello, I would like to help for this issue |
Appreciate the offer @elprogramadorgt! 😃 Feel free to dive in and contribute! |
Thanks @ccamel, I made all the changes, how can I test it? to see if it's working? I already run the commands make install
make build-go
./target/dist/axoned and got no errors, but I would like to confirm before I make my PR |
Awesome @elprogramadorgt! To double-check that everything is working smoothly, you can run the tests with: make test-go Also, just a quick reminder to follow the Conventional Commits for your commit messages and make sure your commits are signed. Thanks for all the effort, this is looking great! |
Thanks @ccamel, I have everything but apparently I don't have access. This is the error remote: Permission to axone-protocol/axoned.git denied to elprogramadorgt. |
@elprogramadorgt Oh, I see. You don’t have direct push access to the repository, so you’ll need to fork the project, create a new branch on your fork, and then push your changes there. After that, you can open a pull request to merge your branch into our repo. For more details, you can check out this guide: Contributing to a project on GitHub. And of course, feel free to reach out if you need any help! |
@ccamel I just have a question on the Makefile, there is this command @go install github.com/golang/mock/[email protected] I don't know how it should be the change for the new library. because when I run that with the new library I have this message. go install go.uber.org/[email protected]
go: go.uber.org/[email protected]: module go.uber.org/[email protected] found, but does not contain package go.uber.org/mock that's the last part I have before making my PR, I submitted 2 but I have some issues that's why I cancel them so I will make a clean PR now |
@elprogramadorgt Absolutely. You need to update the library in the Use the following command for that (cf. official documentation):
|
Hey @ccamel, good news, the PR is ready, sorry for the delay, I had some trouble with some naming conventions but i'ts done! It' was fun, I will see if there something else I can help :) if you have something let me know. and if there is something wrong with my PR also let me know :) |
The current mocking library we use in this repo, golang/mock, has been archived as of June 27, 2023. Following the notice in the repository, I suggest switching to go.uber.org/mock, which is a maintained fork.
The text was updated successfully, but these errors were encountered: