Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Switch mocking library from golang/mock to go.uber.org/mock #770

Closed
ccamel opened this issue Oct 4, 2024 · 9 comments · Fixed by #801
Closed

📌 Switch mocking library from golang/mock to go.uber.org/mock #770

ccamel opened this issue Oct 4, 2024 · 9 comments · Fixed by #801
Assignees
Labels
good first issue Good for newcomers

Comments

@ccamel
Copy link
Member

ccamel commented Oct 4, 2024

The current mocking library we use in this repo, golang/mock, has been archived as of June 27, 2023. Following the notice in the repository, I suggest switching to go.uber.org/mock, which is a maintained fork.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in 💻 Development Oct 4, 2024
@ccamel ccamel moved this from 📋 Backlog to 📆 To do in 💻 Development Oct 4, 2024
@ccamel ccamel added the good first issue Good for newcomers label Oct 7, 2024
@ccamel ccamel pinned this issue Oct 17, 2024
@elprogramadorgt
Copy link
Contributor

Hello, I would like to help for this issue

@ccamel
Copy link
Member Author

ccamel commented Oct 24, 2024

Hello, I would like to help for this issue

Appreciate the offer @elprogramadorgt! 😃 Feel free to dive in and contribute!
Let us know if you have any questions or need guidance.

@elprogramadorgt
Copy link
Contributor

Thanks @ccamel, I made all the changes, how can I test it? to see if it's working?

I already run the commands

make install
make build-go
./target/dist/axoned 

and got no errors, but I would like to confirm before I make my PR

@ccamel
Copy link
Member Author

ccamel commented Oct 25, 2024

Awesome @elprogramadorgt! To double-check that everything is working smoothly, you can run the tests with:

make test-go

Also, just a quick reminder to follow the Conventional Commits for your commit messages and make sure your commits are signed.

Thanks for all the effort, this is looking great!

@elprogramadorgt
Copy link
Contributor

Thanks @ccamel, I have everything but apparently I don't have access. This is the error

remote: Permission to axone-protocol/axoned.git denied to elprogramadorgt.
fatal: unable to access 'https://github.com/axone-protocol/axoned.git/': The requested URL returned error: 403

@ccamel
Copy link
Member Author

ccamel commented Oct 27, 2024

@elprogramadorgt Oh, I see. You don’t have direct push access to the repository, so you’ll need to fork the project, create a new branch on your fork, and then push your changes there. After that, you can open a pull request to merge your branch into our repo. For more details, you can check out this guide: Contributing to a project on GitHub.

And of course, feel free to reach out if you need any help!

@elprogramadorgt
Copy link
Contributor

@ccamel I just have a question on the Makefile, there is this command

@go install github.com/golang/mock/[email protected]

I don't know how it should be the change for the new library.

because when I run that with the new library I have this message.

go install go.uber.org/[email protected] 
go: go.uber.org/[email protected]: module go.uber.org/[email protected] found, but does not contain package go.uber.org/mock

that's the last part I have before making my PR,

I submitted 2 but I have some issues that's why I cancel them so I will make a clean PR now

@ccamel
Copy link
Member Author

ccamel commented Oct 30, 2024

@elprogramadorgt Absolutely. You need to update the library in the Makefile.

Use the following command for that (cf. official documentation):

@go install go.uber.org/mock/[email protected]

@elprogramadorgt
Copy link
Contributor

Hey @ccamel, good news, the PR is ready, sorry for the delay, I had some trouble with some naming conventions but i'ts done! It' was fun, I will see if there something else I can help :) if you have something let me know. and if there is something wrong with my PR also let me know :)

@github-project-automation github-project-automation bot moved this from 📆 To do to ✅ Done in 💻 Development Nov 1, 2024
@ccamel ccamel unpinned this issue Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants