Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update trainer.log signature #2103

Closed
wants to merge 1 commit into from
Closed

fix: update trainer.log signature #2103

wants to merge 1 commit into from

Conversation

NanoCode012
Copy link
Collaborator

@NanoCode012 NanoCode012 commented Nov 25, 2024

Description

Fix nightly test issue (https://github.com/axolotl-ai-cloud/axolotl/actions/runs/12000992306/job/33451164020). Log signature changed upstream huggingface/transformers#34507

  • Requires upstream release for transformers.

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

@NanoCode012 NanoCode012 marked this pull request as draft November 25, 2024 13:51
@winglian
Copy link
Collaborator

winglian commented Nov 25, 2024

upstream tests: https://github.com/axolotl-ai-cloud/axolotl/actions/runs/12013081241

EDIT: these tests look good

@winglian
Copy link
Collaborator

winglian commented Dec 6, 2024

I cherry picked this into #2138

@winglian winglian closed this Dec 6, 2024
@winglian winglian deleted the fix/log_sig branch December 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants