Add plugin manager's callback hooks to training flow #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Oct 30, 2024
winglian
approved these changes
Oct 30, 2024
NanoCode012
reviewed
Oct 31, 2024
bursteratom
pushed a commit
that referenced
this pull request
Nov 18, 2024
* Add plugin manager's callback hooks to training flow * Use .values() instead of .items()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks a lot for creating the plugins system! It has really helped me remove a lot of monkey patching to add my custom callbacks to the Trainer. Now that it exists, all this PR is doing is invoking the callback adding hooks during the training flow allowing plugins to add their own callbacks
I have also made the plugins attribute a OrderedDict so that a plugin is only registered once no matter how many times
.register(...)is called, preventing errorsHow has this been tested?
Using it to run my own plugin for in house Experiment Tracking framework (E.g. https://github.com/truefoundry/llm-finetune/blob/cj_axolotl_update_oct2024/plugins/axolotl_truefoundry/axolotl_truefoundry/__init__.py)
Future Work
Add other methods of the plugin manager in the flow