-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News regexp subst #413
Open
bshifter
wants to merge
11
commits into
axoflow:main
Choose a base branch
from
bshifter:news-regexp-subst
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
News regexp subst #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
refactor to use func-flags to handle flag args Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
…to allow up to 3 digits. The parser now supports up to 3 digits for match group references. If the reference exceeds this limit, the parser exits and treats it as a 3-digit reference. This change prevents excessive greediness in processing match group references and improves performance by limiting the reference size. Additionally, match groups can now include leading zeros, allowing users to reference match groups with fewer than 3 digits before alphanumeric characters. For example, \100000000 will be parsed as match group 100, but by using a prefix like \00100000000, the parser will correctly identify it as match group 1. Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
…of regexp_subst match groups By default, match groups are enabled in regexp_subst. However, this behavior can now be explicitly disabled by setting the optional named argument nogroups=true, as shown: `regexp_subst(target, match_pattern, replace_pattern, nogroups=true);` Signed-off-by: shifter <[email protected]>
… present The function now automatically checks the replacement pattern at config parsing time. If no match group references are found in the pattern, it will behave as if the 'nogroups' option is enabled, disabling match group functionality for performance reasons. Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
bshifter
force-pushed
the
news-regexp-subst
branch
from
December 9, 2024 11:04
5ee88d2
to
9a50213
Compare
alltilla
reviewed
Dec 11, 2024
result = regex_subst("baz,foo,bar", /(\w+),(\w+),(\w+)/, "\\2 \\03 \\1") | ||
|
||
# Force disable this feature | ||
result = regex_subst("baz,foo,bar", /(\w+),(\w+),(\w+)/, "\\2 \\03 \\1", nogroups=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filterx booleans start with lowercase letters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #409