Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add additional ignored flags to sendmail #384

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

lucassabreu
Copy link

sendmail is sometimes used for sending the output of a crontab runtime.

those crontab might send 3 non-mapped options

  • -F - name of the sender
  • -B - configuration bits
  • -e - delivery error behaviour

to not conflict with cron systems i mapped those flags so they don't prevent the e-mail from being sent to mailpit

@axllent
Copy link
Owner

axllent commented Nov 7, 2024

Thanks for this @lucassabreu. I'm really curious about the -e flag, as I cannot find any reference to a sendmail client which supports that. Are you able to provide me with a reference for one that does?

@lucassabreu
Copy link
Author

i was not able to find the link that i found before, not this one from oracle shows it:
https://docs.oracle.com/cd/E19504-01/802-5827/6i9idjvnm/index.html

@axllent
Copy link
Owner

axllent commented Nov 7, 2024

Awesome, thank you. So is -e something you actually need for your setup, or is this something that you just came across and thought to add? The only reason I ask is that there are probably 50 different flags possible if you add up all the different sendmail clients, so I'd prefer to just stick to ones that people need.

@lucassabreu
Copy link
Author

so i added those because of this error that appears, and them the crontab does not work calling it.

if we could just ignore all non-mapped flag, then it would work too.

Error: unknown shorthand flag: 'e' in -em
Usage:
  mailpit sendmail [flags] [recipients]

Flags:
  -f, --from string        SMTP sender (default "root@webpdv-homolog-gama")
  -b, --long-b             Handle SMTP commands on standard input (use as -bs)
  -i, --long-i             Ignored
  -o, --long-o             Ignored
  -s, --long-s             Handle SMTP commands on standard input (use as -bs)
  -t, --long-t             Ignored
  -S, --smtp-addr string   SMTP server address (default "localhost:1025")
  -v, --verbose            Verbose mode (sends debug output to stderr)

@axllent axllent changed the base branch from develop to feature/sendmail-flags November 8, 2024 08:35
@axllent axllent changed the title feat: ignore extra flags from crontab Feature: Add additional ignored flags to sendmail Nov 8, 2024
@axllent axllent merged commit 810e6ff into axllent:feature/sendmail-flags Nov 8, 2024
axllent added a commit that referenced this pull request Nov 8, 2024
commit 5dc0ac63d414d88c516785cba26c5cec24fc817a
Author: Ralph Slooten <[email protected]>
Date:   Fri Nov 8 21:58:46 2024 +1300

    Add new ignored flags to sendmail help

commit 810e6ff
Author: Lucas dos Santos Abreu <[email protected]>
Date:   Fri Nov 8 05:37:27 2024 -0300

    Feature: Add additional ignored flags to sendmail (#384)
@axllent
Copy link
Owner

axllent commented Nov 8, 2024

These additional sendmail flags have been included in v1.12.2. Thank you for your contribution, and please let me know if this solves your cron issue?

@lucassabreu
Copy link
Author

thank you

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 21, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [axllent/mailpit](https://github.com/axllent/mailpit) | minor | `v1.20.7` -> `v1.21.4` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>axllent/mailpit (axllent/mailpit)</summary>

### [`v1.21.4`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1214)

[Compare Source](axllent/mailpit@v1.21.3...v1.21.4)

##### Bugfix

-   Fix external CSS stylesheet loading in HTML preview ([#&#8203;388](axllent/mailpit#388))

### [`v1.21.3`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1213)

[Compare Source](axllent/mailpit@v1.21.2...v1.21.3)

##### Chore

-   Update Go dependencies
-   Minor UI tweaks
-   Mute Dart Sass deprecation notices
-   Update node dependencies
-   Upgrade Alpine packages on Docker build
-   Add swagger examples & API code restructure

### [`v1.21.2`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1212)

[Compare Source](axllent/mailpit@v1.21.1...v1.21.2)

##### Feature

-   Add additional ignored flags to sendmail ([#&#8203;384](axllent/mailpit#384))

##### Chore

-   Remove legacy Tags column from message DB table
-   Update Go dependencies
-   Update node dependencies

##### Fix

-   Fix browser notification request on Edge ([#&#8203;89](axllent/mailpit#89))

### [`v1.21.1`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1211)

[Compare Source](axllent/mailpit@v1.21.0...v1.21.1)

##### Feature

-   Add ability to search by size smaller or larger than a value (eg: `larger:1M` / `smaller:2.5M`)
-   Add ability to search for messages containing inline images (`has:inline`)

##### Chore

-   Update Go dependencies
-   Separate attachments and inline images in download nav and badges ([#&#8203;379](axllent/mailpit#379))

### [`v1.21.0`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1210)

[Compare Source](axllent/mailpit@v1.20.7...v1.21.0)

##### Feature

-   Experimental Unix socket support for HTTPD & SMTPD ([#&#8203;373](axllent/mailpit#373))

##### Fix

-   Allow multiple item selection on macOS with Cmd-click  ([#&#8203;378](axllent/mailpit#378))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants