Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BLS signature tests in develop-ce #155

Closed
jonathanpwang opened this issue Sep 14, 2023 · 1 comment
Closed

Fix BLS signature tests in develop-ce #155

jonathanpwang opened this issue Sep 14, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jonathanpwang
Copy link
Contributor

https://github.com/axiom-crypto/halo2-lib/blob/develop-ce/halo2-ecc/src/bn254/tests/bls_signature.rs

Tests need to be reformatted after v0.4.0 breaking changes. Should be able to copy format of tests/pairing.rs and use the new test suite.

@flyingnobita is a natural person to do this, but also a good few issue for anyone else who want to take it up.
@jonathanpwang jonathanpwang added the good first issue Good for newcomers label Sep 14, 2023
@justcode740 justcode740 mentioned this issue Sep 14, 2023
Merged
@flyingnobita
Copy link
Contributor

Sorry I was at a hackathon yesterday and couldn't respond sooner. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanpwang @flyingnobita