-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genesis, params: add Miko hardfork on mainnet #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way that transactions are processed by Consortium V2 engine allows a system transaction to be placed before a common transaction in a block. However, the generated logs and receipts are ordered so that those of system transactions are stored at the end (see `core/state_processor.go/Process`). This leads to mismatching betwwen logs/receipts and their corresponding transactions because the handler of `eth_getLogs` assume that receipts are stored in the same order with that of `block.Transactions()` (see `core/rawdb/accessors_chain.go/deriveLogFields`).
The check for out-of-order transactions is applied to Miko blocks only.
DNK90
approved these changes
Feb 7, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
* precompiled: add procompiled contract to verify proof of possession BLS * cmd, entrypoint: add an account cmd to generate BLS proof of possession * consortium/v2: upgrade ronin trusted org contract * genesis/testnet: add Miko hardfork on testnet * params/version: bump Ronin to version 2.7.0 * state_processor: fix out-of-order system txs The current way that transactions are processed by Consortium V2 engine allows a system transaction to be placed before a common transaction in a block. However, the generated logs and receipts are ordered so that those of system transactions are stored at the end (see `core/state_processor.go/Process`). This leads to mismatching betwwen logs/receipts and their corresponding transactions because the handler of `eth_getLogs` assume that receipts are stored in the same order with that of `block.Transactions()` (see `core/rawdb/accessors_chain.go/deriveLogFields`). * state_processor, consortium-v2: test out of order system transactions * state_processor: adjust out-of-order tx check The check for out-of-order transactions is applied to Miko blocks only. * genesis, params: add Miko hardfork on mainnet * params/version: bump Ronin to version 2.7.1 --------- Co-authored-by: NganSM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardfork is scheduled at 14:00 UTC + 7 February 26th, 2024 (https://app.roninchain.com/block/32367400)