Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genesis, params: add Miko hardfork on mainnet #402

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

minh-bq
Copy link
Contributor

@minh-bq minh-bq commented Feb 7, 2024

The hardfork is scheduled at 14:00 UTC + 7 February 26th, 2024 (https://app.roninchain.com/block/32367400)

minh-bq and others added 10 commits February 7, 2024 11:32
The current way that transactions are processed by Consortium V2 engine
allows a system transaction to be placed before a common transaction in
a block. However, the generated logs and receipts are ordered so that
those of system transactions are stored at the end (see
`core/state_processor.go/Process`). This leads to mismatching betwwen
logs/receipts and their corresponding transactions because the handler
of `eth_getLogs` assume that receipts are stored in the same order with
that of `block.Transactions()` (see `core/rawdb/accessors_chain.go/deriveLogFields`).
The check for out-of-order transactions is applied to Miko blocks only.
@minh-bq minh-bq requested review from DNK90 and phuctd95 February 7, 2024 04:55
@minh-bq minh-bq merged commit c64ddd3 into axieinfinity:master Feb 7, 2024
1 check passed
@minh-bq minh-bq deleted the feat/release-miko branch February 7, 2024 07:45
Francesco4203 pushed a commit to Francesco4203/ronin that referenced this pull request Jun 18, 2024
* precompiled: add procompiled contract to verify proof of possession BLS

* cmd, entrypoint: add an account cmd to generate BLS proof of possession

* consortium/v2: upgrade ronin trusted org contract

* genesis/testnet: add Miko hardfork on testnet

* params/version: bump Ronin to version 2.7.0

* state_processor: fix out-of-order system txs

The current way that transactions are processed by Consortium V2 engine
allows a system transaction to be placed before a common transaction in
a block. However, the generated logs and receipts are ordered so that
those of system transactions are stored at the end (see
`core/state_processor.go/Process`). This leads to mismatching betwwen
logs/receipts and their corresponding transactions because the handler
of `eth_getLogs` assume that receipts are stored in the same order with
that of `block.Transactions()` (see `core/rawdb/accessors_chain.go/deriveLogFields`).

* state_processor, consortium-v2: test out of order system transactions

* state_processor: adjust out-of-order tx check

The check for out-of-order transactions is applied to Miko blocks only.

* genesis, params: add Miko hardfork on mainnet

* params/version: bump Ronin to version 2.7.1

---------

Co-authored-by: NganSM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants