Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK countries as dependent territories in inclusion rules #365

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

axelboc
Copy link
Collaborator

@axelboc axelboc commented Nov 11, 2020

Fix #361

@axelboc axelboc requested a review from aplaice November 11, 2020 13:16
Copy link
Collaborator

@aplaice aplaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!


<nitpicking_leading_to_nowhere>

I'm not quite sure whether the constituent countries of the UK strictly count as dependent territories. Unlike in the case of the constituent countries of the Kingdoms of the Netherlands or of Denmark, they're not partially independent states, that mostly just share foreign policy/defence. Scotland, Wales and N. Ireland are probably closer to autonomous regions, while England doesn't even have a parliament of its own.

However, given that people generally consider these subdivisions as "important" (more so than, say the Lands of Germany etc.), that the four territories have their own "national" sports teams and that'd it be a shame to remove them, I think that it makes sense to include them under the "dependent territories" umbrella. (Creating a separate category just for the four would feel a bit silly.) Hence, I think that the change is perfect! :)

</nitpicking_leading_to_nowhere>

@axelboc axelboc merged commit 61beb2e into master Nov 11, 2020
@axelboc axelboc deleted the uk-countries branch November 11, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Constituent countries of the UK not covered by inclusion rules
2 participants