Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filds for Area (Km²), Latitude and Longitude #362

Closed
Cardosaum opened this issue Sep 13, 2020 · 4 comments
Closed

Add filds for Area (Km²), Latitude and Longitude #362

Cardosaum opened this issue Sep 13, 2020 · 4 comments
Labels
better-deck-manager Improvements feasible with a better deck manager conception Scope of the deck, memorisation, contribution guidelines, etc.

Comments

@Cardosaum
Copy link

First, I'd like to thank you all for such a great deck.

My question is just like the title:

Would it be possible to add this 3 fields for each country?

I'd like to see something like in this example .

I know that Latitude and Longitude would be approximated values, but I think it's interesting to know that info.

@ohare93
Copy link
Member

ohare93 commented Sep 14, 2020

How is the centre of the Latitude/Longitude calculated for a country? Take the average, or by landmass? 🤔 Some countries this data must be quite useless, like Russia, Canada, or Chile 😅 I am interested to hear the specifics here, I think I could enjoy learning this too 👍


There are lots of requests to add things to the deck, fields such as IPA pronunciation, demonyms, ISO codes, etc, or just more countries / places in general, like the states of the US or the regions of China. In the end there is no way to make everyone happy, that is why it is a better goal to give each user the control to add or remove whatever they wish 😁 👍

We are in the process of moving Ultimate Geography over to a new deck manager Brain Brew, which should allow anyone to create extensions to this deck as separate files 👍 You can see our chat about the general goal in this issue, though I can see you are watching the Brain Brew repo so perhaps you already know 😅

The idea would be that you could make a repo for UG which just holds the extended info you wish to add (Area, Latitude, and Longitude, in this case) for each relevant Country, and could be responsible for it and generate the decks independently for yourself and/or others 👍 Though all the logistics of where that repo will be and what are best practices have not yet been worked out 😅 but we'll get there! 😁 if you wish to start now then you can have a look at the working version on my move-to-brain-brew branch of UG and fork it. You'll just need to add your extra data as a csv, with the right data, and add that as a file in the builder file. See my comments here for more info, as I have not yet created the new documentation as things are constantly in flux in my little fledgling project. Ahh, but now I see you have already liked that comment, perhaps you knew everything I said here already 😅 ahh fuck it, I hope something here is helpful! 😁 🤷‍♂️ feel free to ping me any questions 👏

@axelboc axelboc added the better-deck-manager Improvements feasible with a better deck manager label Sep 14, 2020
@axelboc axelboc added the conception Scope of the deck, memorisation, contribution guidelines, etc. label Sep 14, 2020
@axelboc
Copy link
Collaborator

axelboc commented Sep 14, 2020

Closing but leaving the tag on so we can find the issue again when the ecosystem is ready. Feel free to keep discussing lat/long here. 😉

@axelboc axelboc closed this as completed Sep 14, 2020
@Cardosaum
Copy link
Author

How is the centre of the Latitude/Longitude calculated for a country? Take the average, or by landmass?

lol

Yeah, I should had been more detailed...

I was thinking to add Latitude and Longitude related to Countries' Capitals. So,
for Russia, as you said, we could round the Latitude and Longitude's exact values
(55.751244, 37.618423) for 2 decimals for example.

Doing so we wouldn't have a good overview of the spread of the country though.

Another option I see is to add Latitude and Longitude for extreme points of the
Country. (US example).


In the end there is no way to make everyone happy, that is why it is a better goal to give each user the control to add or remove whatever they wish

You're definitely right.

I just thought that (at least for Area) the information would be pretty
standard, more people would like the idea and you guys would like to add it
to mainstream. (No prob at all if you prefer to put it in an "extension deck" rather
than mainstream, though)


Thanks for pointing me out to #4 😄 , I was not aware of this issue.
I'll need some free time to read the full discussion. (Maybe Saturday?)


Though all the logistics of where that repo will be and what are best practices have not yet been worked out 😅 but we'll get there!

I'll follow the discussions related to this topic. It's a really important one for this project.

I appreciate the information you provided to help me start to work in the csv files, but I think I'll wait until Brain Brew get the final adjustments (and I need to have a little more free time haha).

Oh, btw, You are doing a really good work on your "little fledgling project"!


Finaly, I'd like to thank you for such a detailed comment! It was really helpfull.

@ohare93
Copy link
Member

ohare93 commented Sep 15, 2020

Another option I see is to add Latitude and Longitude for extreme points of the
Country. (US example).

This sounds more useful imo 👍

I just thought that (at least for Area) the information would be pretty standard

Definitely! If we first agree which islands/territories do or do not get included 😉 but in the end there'll be an answer

Thanks for pointing me out to #4 , I was not aware of this issue.
I'll need some free time to read the full discussion. (Maybe Saturday?)

Completely understandable! 😆 our passion is only matched by our verbosity! 😅

I'll follow the discussions related to this topic. It's a really important one for this project.

I appreciate the information you provided to help me start to work in the csv files, but I think I'll wait until Brain Brew get the final adjustments (and I need to have a little more free time haha).

👍

Oh, btw, You are doing a really good work on your "little fledgling project"!

God damn, why am I so conflicted about this very very nice complement? 😅 it's like, if I accept your suggestion Brain Brew is in fact not a "little fledgling project" then that means I am doing/have done something that is extensive/mature 😰 and nonono my brain much prefers: "little bedroom free-time project only that took a few weekends" 😆 even if that may not fit with the reality 😉 but thanks mate, it is much appreciated

Finaly, I'd like to thank you for such a detailed comment! It was really helpfull.

👍 most times!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-deck-manager Improvements feasible with a better deck manager conception Scope of the deck, memorisation, contribution guidelines, etc.
Development

No branches or pull requests

3 participants