Adds httpChecksum trait support #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
requested review from
JordonPhillips,
kstich and
mtdowling
as code owners
mtdowling
requested changes
Jun 24, 2021
skotambkar
force-pushed
the
httpchecksum-2.0
branch
from
4601cc2 to
4b31a6f
Compare
skotambkar
force-pushed
the
httpchecksum-2.0
branch
from
4b31a6f to
8eb0cb3
Compare
kstich
requested changes
Jul 1, 2021
smithy-model/src/main/java/software/amazon/smithy/model/traits/HttpChecksumProperty.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/HttpChecksumProperty.java
Outdated
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/smithy/model/validation/validators/HttpChecksumTraitValidator.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy
Outdated
Show resolved
Hide resolved
Merged
kstich
approved these changes
Jul 14, 2021
JordonPhillips
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Needs review
Description of changes:
[x] Adds httpChecksum trait to smithy.
[x] Adds test cases and docs
Replaces #741
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.