Fix openapi greedy param names for API Gateway REST APIs #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
requested changes
Dec 16, 2020
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Outdated
Show resolved
Hide resolved
smithy-openapi/src/main/java/software/amazon/smithy/openapi/OpenApiConfig.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultRestConfigSettings.java
Show resolved
Hide resolved
smithy-openapi/src/main/java/software/amazon/smithy/openapi/OpenApiConfig.java
Show resolved
Hide resolved
JordonPhillips
approved these changes
Dec 17, 2020
kstich
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For OpenAPI, "greedy" labels need a corresponding name parameter, which was added in #641.
However, some vendors/tooling, including REST APIs for API Gateway, require that the name parameter exclude the "+" suffix in the generated name parameter.
This CR adds an option to configure OpenApiConfig to remove that suffix, which is then used as the default for REST APIs in smithy-aws-apigateway-openapi.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.