Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expand Dockerfile support #1140

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

dnys1
Copy link
Contributor

@dnys1 dnys1 commented Mar 17, 2022

Issue #, if available:
The current Dockerfile expects a pre-built CLI artifact and does not bundle trait JARs.

Description of changes:

  • Compile Smithy CLI and traits in separate Docker stage
  • Include trait jars in exec stage

Example usage

To build:

docker build -t smithy .

Then, given I'm in a directory with some Smithy files:

./main.smithy
./user.smithy

To print AST:

docker run --rm -v $PWD:/models smithy ast -d /smithy/lib/traits /models

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dnys1 dnys1 requested a review from a team as a code owner March 17, 2022 18:24
@mtdowling mtdowling merged commit ed259d4 into smithy-lang:main Mar 23, 2022
@dnys1 dnys1 deleted the chore/improve-dockerfile branch March 23, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants